From patchwork Sun Jun 12 10:52:33 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wanlong Gao X-Patchwork-Id: 872792 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p5CArCL2019933 for ; Sun, 12 Jun 2011 10:53:13 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753163Ab1FLKxC (ORCPT ); Sun, 12 Jun 2011 06:53:02 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:57568 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753016Ab1FLKxB (ORCPT ); Sun, 12 Jun 2011 06:53:01 -0400 Received: by pwi15 with SMTP id 15so1763485pwi.19 for ; Sun, 12 Jun 2011 03:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:subject:from:to:cc:content-type:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=zX3fA33v5Plej7p1/nRBcl2o+dzi1PtBHrpy0NF+44k=; b=uKQkU8r7I3i9gwp3mysHBy7kpABH/asYNiawz9WIZx7aoNmUiHj9oo0ktBDLd+QUz3 06SFmI7eXrPTALufFoVuLO1CUG+zdt8S4B5JZwn9YVlIJ1/6qQZUSyQ6yA+tWyH1N3RL ykixtXAS2fFTyOGubYMomxNxWIGrJpfHUgYh8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=n7d2uDGXq9tor4YUftChksqlrX2kgTFClMrdrSWwt9O7jSi1Nf2x2tq4BBauBz8v0J R/K00zgGgnEJYMcMeREBK2tyxv++rJn7Q57T2xYAR8/ELio1iT7qLRxOhU2IVwWFHNKE Z6PmWppMB4ccRZscLa5e/l/jIPnS3If4fgWIg= Received: by 10.68.34.74 with SMTP id x10mr1732067pbi.175.1307875981129; Sun, 12 Jun 2011 03:53:01 -0700 (PDT) Received: from [192.168.0.103] ([182.32.129.92]) by mx.google.com with ESMTPS id y2sm3768692pbg.72.2011.06.12.03.52.39 (version=SSLv3 cipher=OTHER); Sun, 12 Jun 2011 03:52:59 -0700 (PDT) Subject: re:[PATCH] efifb: Fix call to wrong unregister function From: "wanlong.gao" To: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: Maarten Lankhorst , Maarten Lankhorst , Peter Jones Date: Sun, 12 Jun 2011 18:52:33 +0800 Message-ID: <1307875953.1859.6.camel@Tux> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Sun, 12 Jun 2011 10:53:13 +0000 (UTC) Hi Maarten: It registered efifb_device but try to unregistered efifb_driver, so I think you should fix it like this? Signed-off-by: Wanlong Gao Signed-off-by: Maarten Lankhorst Acked-by: Andy Lutomirski --- drivers/video/efifb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c index 69c49df..784139a 100644 --- a/drivers/video/efifb.c +++ b/drivers/video/efifb.c @@ -541,7 +541,7 @@ static int __init efifb_init(void) */ ret = platform_driver_probe(&efifb_driver, efifb_probe); if (ret) { - platform_device_unregister(&efifb_driver); + platform_device_unregister(&efifb_device); return ret; }