| Message ID | 1308043507-11083-12-git-send-email-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | df2d79810930ead3112b4ebab86ea0f9229ccf70 |
| Headers | show |
diff --git a/drivers/video/hgafb.c b/drivers/video/hgafb.c index 4052718..4394389 100644 --- a/drivers/video/hgafb.c +++ b/drivers/video/hgafb.c @@ -422,8 +422,8 @@ static int hgafb_pan_display(struct fb_var_screeninfo *var, var->xoffset) return -EINVAL; } else { - if (var->xoffset + var->xres > info->var.xres_virtual - || var->yoffset + var->yres > info->var.yres_virtual + if (var->xoffset + info->var.xres > info->var.xres_virtual + || var->yoffset + info->var.yres > info->var.yres_virtual || var->yoffset % 8) return -EINVAL; }
We must not use any information in the passed var besides xoffset, yoffset and vmode as otherwise applications might abuse it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Ferenc Bakonyi <fero@drama.obuda.kando.hu> Cc: Brent Cook <busterb@gmail.com> --- drivers/video/hgafb.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)