From patchwork Wed Jun 15 01:09:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wanlong Gao X-Patchwork-Id: 880732 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p5F19cbq029592 for ; Wed, 15 Jun 2011 01:09:38 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754298Ab1FOBJh (ORCPT ); Tue, 14 Jun 2011 21:09:37 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:46884 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753709Ab1FOBJg (ORCPT ); Tue, 14 Jun 2011 21:09:36 -0400 Received: by pzk9 with SMTP id 9so2919898pzk.19 for ; Tue, 14 Jun 2011 18:09:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:subject:from:to:cc:content-type:date:message-id :mime-version:x-mailer; bh=o7EZJ/A08HiC0J5uZR3Yfaf7P2oP/BzkfzOo8qNId88=; b=klU6gyytFIkNiPbHZIAV28T6PAY+N6VsSryJnSF00IqN09OOE3l35Y5nvvEEUNehHa WmH0hYk5QfEw/XewMfGKB4xvm18OhDCmgJtb7/SqEsWM0xqFF6YXu6akx61ckoUPN5Gf 5gT+NDZFQSGvOas2BXK4IM7MorhFd2vyp+BJY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer; b=YSni8rfkIaW0nUfdxbzKvVO19DeQCCIoq8Ho+bEzqHOat0U4IwEpbLXTVFnj4qt+iE +2rjWkwEZ8KJ85yOKbBDIWEWYU6MhnqTwpJCJucE7r4ToESNb27EIz+cjgnMvsFLtaFl V/QNoPcpE39II6i+ObQ5Ay7Nuxkmm1BcvHPww= Received: by 10.142.9.36 with SMTP id 36mr1299285wfi.125.1308100176378; Tue, 14 Jun 2011 18:09:36 -0700 (PDT) Received: from [192.168.0.103] ([182.32.128.85]) by mx.google.com with ESMTPS id 10sm5807224pbk.45.2011.06.14.18.09.28 (version=SSLv3 cipher=OTHER); Tue, 14 Jun 2011 18:09:34 -0700 (PDT) Subject: re:Possible deadlock when suspending framebuffer From: Wanlong Gao To: Francis Moreau Cc: Paul Mundt , linux-fbdev@vger.kernel.org, Linux Kernel Mailing List , Francis Moreau , Linus Torvalds Date: Wed, 15 Jun 2011 09:09:24 +0800 Message-ID: <1308100165.2113.4.camel@Tux> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 15 Jun 2011 01:09:38 +0000 (UTC) Hi Francis: can you test this patch? Thanks From fe026c42af4cbdce053460a428a445e99071586a Mon Sep 17 00:00:00 2001 From: Wanlong Gao Date: Wed, 15 Jun 2011 09:03:41 +0800 Subject: [PATCH] test Signed-off-by: Wanlong Gao --- drivers/video/fbmem.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) return -EINVAL; From fe026c42af4cbdce053460a428a445e99071586a Mon Sep 17 00:00:00 2001 From: Wanlong Gao Date: Wed, 15 Jun 2011 09:03:41 +0800 Subject: [PATCH] test test Signed-off-by: Wanlong Gao --- drivers/video/fbmem.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c index 5aac00e..6e6cef3 100644 --- a/drivers/video/fbmem.c +++ b/drivers/video/fbmem.c @@ -1642,11 +1642,8 @@ static int do_unregister_framebuffer(struct fb_info *fb_info) if (i < 0 || i >= FB_MAX || registered_fb[i] != fb_info) return -EINVAL; - if (!lock_fb_info(fb_info)) - return -ENODEV; event.info = fb_info; ret = fb_notifier_call_chain(FB_EVENT_FB_UNBIND, &event); - unlock_fb_info(fb_info); if (ret) return -EINVAL; -- 1.7.4.1