| Message ID | 1344097153-13903-1-git-send-email-notasas@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, 2012-08-04 at 19:19 +0300, Grazvydas Ignotas wrote: > omapfb does not currently set pseudo palette correctly for color depths > above 16bpp, making red text invisible, command like > echo -e '\e[0;31mRED' > /dev/tty1 > will display nothing on framebuffer console in 24bpp mode. > This is because temporary variable is declared incorrectly, fix it. Thanks, applied to OMAP DSS tree. Tomi
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/06/12 09:00, Tomi Valkeinen wrote: > On Sat, 2012-08-04 at 19:19 +0300, Grazvydas Ignotas wrote: >> omapfb does not currently set pseudo palette correctly for color depths >> above 16bpp, making red text invisible, command like >> echo -e '\e[0;31mRED' > /dev/tty1 >> will display nothing on framebuffer console in 24bpp mode. >> This is because temporary variable is declared incorrectly, fix it. > > Thanks, applied to OMAP DSS tree. Is it also applicable to stable? If yes, Tomi, can you please add the Cc tag? Thanks - -- Regards, Igor. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJQH5lGAAoJEBDE8YO64Efak/YP/3APyqQ3d4TLB8sG7oHSF/Vn zmwMl8kH2B70WIPWU1iIExodfrDd3Gms8UeGqjhj04kLHvqYUs3/lepTA6gkEnH0 U4vyO6WTMYtWBHUGXJhZk5GpOByn4aLdk4UGV22NNMmUI/xWqcVGSnntLjmRcUyu Y1JRQqhlrXrYXH5A866J7yrwSwhhZ/sZXs4k1N5keCNaT8ieqn0HXvu02ma7bjF7 SvhWDPNOOWUuEOGsope8F2A8Mot4ToManqRHDTUSnq/cpWziGiy6/7I7ngVIMUgD /nmiLISgU72wkoNDl0AxGQDVQ8HFUspzGe2e12VliG+ErmFkGfKr9XdI6fx7gKh2 ks7qL+uMBau9MpWYcRPhPvYrVn7tg6V9seN2/bG5gp2IgMFbu1wmibVMNyCGhQeX 1OhshGEKeR58s+R8KZ7+UzbjspDuSnlnFH2wVbbb3wr30Swc6VZA/rWlwNg3Bgz5 /h63a5SOwTF9nmV+3/O/ky4gyMORbbJyOBK/xWVmQkZ4lNNW02RnMaa6KP8fKlbb Cc7x1P07jcMH83LKGyyhsvZrK/4JCloYEDTvuYHprf9Wb+WsXNCLsRiYMngUIwPc eLrBVOlELQvS237eGAwMIfo4Lm3tI3WMyr8cjGy2aRqn8voDJW+qEN2NUNwkNDqS kGYrOE0t5VRNx5egrv+J =kydA -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2012-08-06 at 13:15 +0300, Igor Grinberg wrote: > On 08/06/12 09:00, Tomi Valkeinen wrote: > > On Sat, 2012-08-04 at 19:19 +0300, Grazvydas Ignotas wrote: > >> omapfb does not currently set pseudo palette correctly for color depths > >> above 16bpp, making red text invisible, command like > >> echo -e '\e[0;31mRED' > /dev/tty1 > >> will display nothing on framebuffer console in 24bpp mode. > >> This is because temporary variable is declared incorrectly, fix it. > > > > Thanks, applied to OMAP DSS tree. > > Is it also applicable to stable? > If yes, Tomi, can you please add the Cc tag? Yes, the bug has been there from the beginning. I can add the Cc tag. But I wonder is it enough just to have the tag, or should I also send the patch forward? And does it only get applied to the latest stable tree, not the earlier ones? Tomi
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/06/12 14:22, Tomi Valkeinen wrote: > On Mon, 2012-08-06 at 13:15 +0300, Igor Grinberg wrote: >> On 08/06/12 09:00, Tomi Valkeinen wrote: >>> On Sat, 2012-08-04 at 19:19 +0300, Grazvydas Ignotas wrote: >>>> omapfb does not currently set pseudo palette correctly for color depths >>>> above 16bpp, making red text invisible, command like >>>> echo -e '\e[0;31mRED' > /dev/tty1 >>>> will display nothing on framebuffer console in 24bpp mode. >>>> This is because temporary variable is declared incorrectly, fix it. >>> >>> Thanks, applied to OMAP DSS tree. >> >> Is it also applicable to stable? >> If yes, Tomi, can you please add the Cc tag? > > Yes, the bug has been there from the beginning. > > I can add the Cc tag. But I wonder is it enough just to have the tag, or > should I also send the patch forward? And does it only get applied to > the latest stable tree, not the earlier ones? Well, the Documentation/stable_kernel_rules.txt says: - To have the patch automatically included in the stable tree, add the tag Cc: stable@vger.kernel.org in the sign-off area. Once the patch is merged it will be applied to the stable tree without anything else needing to be done by the author or subsystem maintainer. So I guess, you don't need to resend it. Also, IIUC, if you can identify all the stable kernels it applies to, you can specify them like: Cc: <stable@vger.kernel.org> # 3.x, 2.6.x This can save some work for those responsible for adding the patch to stable. Now, if you say, it is applicable to all kernels since the omapfb support was merged, I think, the above example it the right choice. Anyway, Greg, please correct me if I've got anything wrong. Thanks - -- Regards, Igor. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJQH7gRAAoJEBDE8YO64EfakCAP/izNPA/HcFhxE3cRJJhlh5xw Caf4h6gXjdTNekSfLEppyo+uf6F2ef8ojZFoim1x59phjC9N9TQWyqTgV6qTGWul o8YtCo3CMXPTVnxgoYtIFNDIngiuZFVATEWdoHlxlpWwBXWcr6K101Rg+x0hlvzl CAqquuwjO+GFmPn+6hLns3sFJcnD02e2Rb0tX29Yg/SdFCMPDIRA3NUANVqILcxN do6mWpZ3tKOmPzobUDr1tswJxK94oc0pIjKMjxy71qAxpLMtY2bVNKavKuGsgaRr Nl7Bml5e1vCvAJNtYTpiMKvjomTvS1gktBoAa43u81THDrvwzJNO/mUq88CuMOg0 D0k8ohKrv0/WyKr+LZe9W4l4I9lIvbutvF5oxcU+1gC01pMlr9qghO8J3Oz5/UTi /Swd7Q5I6X29TtudIuAsZ8g5didNBTLYgih+DODviTRzaca7msF+VfNkcg2IeOuA MvkMwiZSZX15ggriH07dEr+Z2XF7mMYVMgn492RokMzeXx31VXeHYv9pNGXcF+xn xV55Z03RT2jcnIPJVSfnzXAXIhTdkM2MVBaS/iNKckPW1Q1quiY/7IeWJaX59LBl bWUIFC02HJ+n8S2Tyqbr+7+0ue6v3xVocw/fcwx0PCLx0HltxhrAJJzTB+o4SDya DpSx1+W2seaVbd7AgkmN =qbs/ -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c index 70aa47d..f7c1753 100644 --- a/drivers/video/omap2/omapfb/omapfb-main.c +++ b/drivers/video/omap2/omapfb/omapfb-main.c @@ -1183,7 +1183,7 @@ static int _setcolreg(struct fb_info *fbi, u_int regno, u_int red, u_int green, break; if (regno < 16) { - u16 pal; + u32 pal; pal = ((red >> (16 - var->red.length)) << var->red.offset) | ((green >> (16 - var->green.length)) <<
omapfb does not currently set pseudo palette correctly for color depths above 16bpp, making red text invisible, command like echo -e '\e[0;31mRED' > /dev/tty1 will display nothing on framebuffer console in 24bpp mode. This is because temporary variable is declared incorrectly, fix it. Signed-off-by: Grazvydas Ignotas <notasas@gmail.com> --- drivers/video/omap2/omapfb/omapfb-main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)