From patchwork Wed Aug 8 03:54:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 1292411 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 730F6DF223 for ; Wed, 8 Aug 2012 03:54:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756475Ab2HHDyp (ORCPT ); Tue, 7 Aug 2012 23:54:45 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:58980 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756528Ab2HHDyo (ORCPT ); Tue, 7 Aug 2012 23:54:44 -0400 Received: by yenl2 with SMTP id l2so350070yen.19 for ; Tue, 07 Aug 2012 20:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=oPc6avTediIb3vE9fNI2ZfME812VJjSF1UXpGBSb11E=; b=FpabImuFEDGZx38Yn6SI8fcGuQPtfObfogievRapSS0+b2mEzYFub2taDn50tldCfo VeIRu6ID0h2D5+HlMvYxKFC4zLbhvQR03JlZJMZ1Y6DvLCCBnqcM43lHvuEqDFzb8Jrx zNXyMPMZs+JJ1XPji1UZNVLOpxdoDdDzmZPtg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=oPc6avTediIb3vE9fNI2ZfME812VJjSF1UXpGBSb11E=; b=AHym9hqfo588mJNkSc+KfJr8iICHfdZHh4HALV1UgyCWFk6mMKN6P6BJeweqYCwHfX LcWOcKkqyNW1Sb5jaHqFPnxj/Hc5+GAeIiNriobD6c1YyREArN1i6xs+l7XOFnEKLdvv PSoyYPdnNxW02cM5KJ9/pylvAMK7mMmopxh1YGOzYoUBnMRfMki369vDw4F+x41eQQNe zaVJO3fagiepw5B1LvtVgZ7oIp+MYcjsDmpbldJowou2xb9efooi/qTpEF70oohxji1t rst4Ta6hrDgPEV3aMNCAhemhZymI/N7eNtGe73MBkg24dd//3Q3DgQBjcFjtuqxv3sd/ DYHA== Received: by 10.66.90.67 with SMTP id bu3mr30716227pab.26.1344398083418; Tue, 07 Aug 2012 20:54:43 -0700 (PDT) Received: from anush.mtv.corp.google.com (anush.mtv.corp.google.com [172.22.73.28]) by mx.google.com with ESMTPS id hx9sm12461756pbc.68.2012.08.07.20.54.42 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 07 Aug 2012 20:54:42 -0700 (PDT) From: Sean Paul To: jg1.han@samsung.com, linux-fbdev@vger.kernel.org Cc: Sean Paul Subject: [PATCH 09/10] video: exynos_dp: Fix bug when checking dp->irq Date: Tue, 7 Aug 2012 20:54:23 -0700 Message-Id: <1344398064-13563-10-git-send-email-seanpaul@chromium.org> X-Mailer: git-send-email 1.7.7.3 In-Reply-To: <1344398064-13563-1-git-send-email-seanpaul@chromium.org> References: <1344398064-13563-1-git-send-email-seanpaul@chromium.org> X-Gm-Message-State: ALoCoQlSkWdfIiulmNudlPj0oCu5vA2ACNw+2k8hqhKyjM4+oevv49trPcdFMahQ9XRRd8/SoMtZ Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Fix a bug where we check !dp->irq instead of the correct check for -ENXIO. BUG=None TEST=None Change-Id: Ibcdd16fb71eb41e4380ac8911ad6063634ff80e2 Signed-off-by: Sean Paul Reviewed-on: https://gerrit.chromium.org/gerrit/29144 Reviewed-by: Olof Johansson --- drivers/video/exynos/exynos_dp_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/exynos/exynos_dp_core.c b/drivers/video/exynos/exynos_dp_core.c index 68ad494..eb5816f 100644 --- a/drivers/video/exynos/exynos_dp_core.c +++ b/drivers/video/exynos/exynos_dp_core.c @@ -919,7 +919,7 @@ static int __devinit exynos_dp_probe(struct platform_device *pdev) } dp->irq = platform_get_irq(pdev, 0); - if (!dp->irq) { + if (dp->irq == -ENXIO) { dev_err(&pdev->dev, "failed to get irq\n"); ret = -ENODEV; goto err_clock;