From patchwork Wed Aug 8 03:54:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 1292371 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id AA5DADF223 for ; Wed, 8 Aug 2012 03:54:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756472Ab2HHDyk (ORCPT ); Tue, 7 Aug 2012 23:54:40 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:48841 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756260Ab2HHDyj (ORCPT ); Tue, 7 Aug 2012 23:54:39 -0400 Received: by mail-pb0-f46.google.com with SMTP id rr13so760482pbb.19 for ; Tue, 07 Aug 2012 20:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=SJkimElSTKJ3rqPc8+xSqZN8G2mz+lalDb1cRS5FTGM=; b=JOq+ZbvqZ3J0t7jcwDnzhn4WPyWBDKed10ewlM/wYqzwIyEg8C3CRmubZbS3jlKo7M x/ozg1gAG4g/6n8UBt98t7UaUzuJUbKBEYegEqzYD3w/bb6KzEqdHfn1STkNbHPKDhzX H4kK1TRuBocWSMvN+M4bW6sCwYr+RVEHqVavE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=SJkimElSTKJ3rqPc8+xSqZN8G2mz+lalDb1cRS5FTGM=; b=S9MxEwPvJA3+rm9wCatzEEJirbfbt4DlWYlNH4jDOtJBMhhShvXms3Ik9+yudptZAB /y57zY/4YyuKbV9HIYyAZE+9cnTEVs5KNxTNF3d99eqmw2IJ2+EN5Cfjwbj3iOTizoHq 35TcLk4w9bWW6Kb2K/hRrTVOtb5tNo5LzJvchZpmGlgpDpyC/pahAPpJ/ld0G+4K3ZEn YEzJymJz6tAV7CBz39hptq0r9pQA8I8nZH6JdQL2To5xeYX/f7ucJyAlkCGhpZdQWPHg go+QyDj+nEPTFgp50Kj2oyWrgnoKClojeilMfBpu0u85apwxXICat9nrMboHyxhPRjK4 8fnw== Received: by 10.68.213.5 with SMTP id no5mr33371930pbc.24.1344398079257; Tue, 07 Aug 2012 20:54:39 -0700 (PDT) Received: from anush.mtv.corp.google.com (anush.mtv.corp.google.com [172.22.73.28]) by mx.google.com with ESMTPS id hx9sm12461756pbc.68.2012.08.07.20.54.38 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 07 Aug 2012 20:54:38 -0700 (PDT) From: Sean Paul To: jg1.han@samsung.com, linux-fbdev@vger.kernel.org Cc: Sean Paul Subject: [PATCH 05/10] video: exynos_dp: Remove sink control to D0 Date: Tue, 7 Aug 2012 20:54:19 -0700 Message-Id: <1344398064-13563-6-git-send-email-seanpaul@chromium.org> X-Mailer: git-send-email 1.7.7.3 In-Reply-To: <1344398064-13563-1-git-send-email-seanpaul@chromium.org> References: <1344398064-13563-1-git-send-email-seanpaul@chromium.org> X-Gm-Message-State: ALoCoQlfZm3dRueAbm5FztGEwR/XQeumJa4Bb7QNITG2uDVdsM8WGaU04EIaSnW13c20cHiXm4TG Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Don't reset the sink power to D0. Removing this for three reasons: 1) It's not required in the SW link training documentation 2) The comment is incorrect, D0 is normal operation, not "power down" 3) It seems to change things in the link training that causes glitches Signed-off-by: Sean Paul --- drivers/video/exynos/exynos_dp_core.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/video/exynos/exynos_dp_core.c b/drivers/video/exynos/exynos_dp_core.c index 207bd7e..1c998d9 100644 --- a/drivers/video/exynos/exynos_dp_core.c +++ b/drivers/video/exynos/exynos_dp_core.c @@ -273,12 +273,6 @@ static int exynos_dp_link_start(struct exynos_dp_device *dp) for (lane = 0; lane < lane_count; lane++) dp->link_train.cr_loop[lane] = 0; - /* Set sink to D0 (Sink Not Ready) mode. */ - ret = exynos_dp_write_byte_to_dpcd(dp, DPCD_ADDR_SINK_POWER_STATE, - DPCD_SET_POWER_STATE_D0); - if (ret) - return ret; - /* Set link rate and count as you want to establish*/ exynos_dp_set_link_bandwidth(dp, dp->link_train.link_rate); exynos_dp_set_lane_count(dp, dp->link_train.lane_count);