| Message ID | 1351613409-21186-2-git-send-email-tomi.valkeinen@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tuesday 30 October 2012 09:39 PM, Tomi Valkeinen wrote: > It seems that using the second EDID block causes more problems than is > of any help. The first mode in the extended block will get > FB_MODE_IS_FIRST set, which will override the first mode from the first > EDID block, thus making the default videomode selection not to work > properly. > > This patch removes the use of the extended edid block for now. Looks like you had posted this one(and also the next one)in the previous cleanup/fixes series also. Archit -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2012-10-31 08:10, Archit Taneja wrote: > On Tuesday 30 October 2012 09:39 PM, Tomi Valkeinen wrote: >> It seems that using the second EDID block causes more problems than is >> of any help. The first mode in the extended block will get >> FB_MODE_IS_FIRST set, which will override the first mode from the first >> EDID block, thus making the default videomode selection not to work >> properly. >> >> This patch removes the use of the extended edid block for now. > > Looks like you had posted this one(and also the next one)in the previous > cleanup/fixes series also. Ah, so I did. Too many work branches =). Thanks for pointing it out. Tomi
diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c index bc225e4..0358b14 100644 --- a/drivers/video/omap2/omapfb/omapfb-main.c +++ b/drivers/video/omap2/omapfb/omapfb-main.c @@ -2274,9 +2274,6 @@ static int omapfb_find_best_mode(struct omap_dss_device *display, fb_edid_to_monspecs(edid, specs); - if (edid[126] > 0) - fb_edid_add_monspecs(edid + 0x80, specs); - best_xres = 0; best_idx = -1;
It seems that using the second EDID block causes more problems than is of any help. The first mode in the extended block will get FB_MODE_IS_FIRST set, which will override the first mode from the first EDID block, thus making the default videomode selection not to work properly. This patch removes the use of the extended edid block for now. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> --- drivers/video/omap2/omapfb/omapfb-main.c | 3 --- 1 file changed, 3 deletions(-)