| Message ID | 1360752028-7301-4-git-send-email-maxime.ripard@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/drivers/video/backlight/hx8357.c b/drivers/video/backlight/hx8357.c index 2691fd6..7c82561 100644 --- a/drivers/video/backlight/hx8357.c +++ b/drivers/video/backlight/hx8357.c @@ -96,10 +96,8 @@ static int hx8357_spi_write_then_read(struct lcd_device *lcdev, local_txbuf = kcalloc(txlen, sizeof(*local_txbuf), GFP_KERNEL); - if (!local_txbuf) { - dev_err(&lcdev->dev, "Couldn't allocate data buffer.\n"); + if (!local_txbuf) return -ENOMEM; - } for (i = 0; i < txlen; i++) { local_txbuf[i] = txbuf[i];
In case of a failing allocation, a dump stack will be printed anyway, so the dev_err is redundant. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- drivers/video/backlight/hx8357.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)