| Message ID | 1362431000-15141-2-git-send-email-aaro.koskinen@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, * Aaro Koskinen <aaro.koskinen@iki.fi> [130304 13:08]: > Fix the following build regression in 3.9-rc1 by including > <machine/hardware.h>: > > drivers/video/omap/lcd_ams_delta.c: In function 'ams_delta_lcd_set_power': > drivers/video/omap/lcd_ams_delta.c:48:4: error: implicit declaration of function 'omap_writeb' [-Werror=implicit-function-declaration] > drivers/video/omap/lcd_ams_delta.c:49:6: error: 'OMAP_PWL_ENABLE' undeclared (first use in this function) > drivers/video/omap/lcd_ams_delta.c:49:6: note: each undeclared identifier is reported only once for each function it appears in > drivers/video/omap/lcd_ams_delta.c:50:19: error: 'OMAP_PWL_CLK_ENABLE' undeclared (first use in this function) > drivers/video/omap/lcd_ams_delta.c: In function 'ams_delta_lcd_set_contrast': > drivers/video/omap/lcd_ams_delta.c:66:22: error: 'OMAP_PWL_ENABLE' undeclared (first use in this function) I have this already queued up in omap-for-v3.9-rc1/fixes as 0adcbaf78 (ARM: OMAP1: Fix build related to kgdb.h no longer including serial_8250.h) and for lcd_osk.c as omap1_defconfig was broken. I don't anything for the first patch you posted, so I suggest Tomi applies that one. Regards, Tony > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> > --- > drivers/video/omap/lcd_ams_delta.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/omap/lcd_ams_delta.c b/drivers/video/omap/lcd_ams_delta.c > index ed4cad8..4a5f2cd 100644 > --- a/drivers/video/omap/lcd_ams_delta.c > +++ b/drivers/video/omap/lcd_ams_delta.c > @@ -27,6 +27,7 @@ > #include <linux/lcd.h> > #include <linux/gpio.h> > > +#include <mach/hardware.h> > #include <mach/board-ams-delta.h> > > #include "omapfb.h" > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2013-03-05 00:39, Tony Lindgren wrote: > Hi, > > * Aaro Koskinen <aaro.koskinen@iki.fi> [130304 13:08]: >> Fix the following build regression in 3.9-rc1 by including >> <machine/hardware.h>: >> >> drivers/video/omap/lcd_ams_delta.c: In function 'ams_delta_lcd_set_power': >> drivers/video/omap/lcd_ams_delta.c:48:4: error: implicit declaration of function 'omap_writeb' [-Werror=implicit-function-declaration] >> drivers/video/omap/lcd_ams_delta.c:49:6: error: 'OMAP_PWL_ENABLE' undeclared (first use in this function) >> drivers/video/omap/lcd_ams_delta.c:49:6: note: each undeclared identifier is reported only once for each function it appears in >> drivers/video/omap/lcd_ams_delta.c:50:19: error: 'OMAP_PWL_CLK_ENABLE' undeclared (first use in this function) >> drivers/video/omap/lcd_ams_delta.c: In function 'ams_delta_lcd_set_contrast': >> drivers/video/omap/lcd_ams_delta.c:66:22: error: 'OMAP_PWL_ENABLE' undeclared (first use in this function) > > I have this already queued up in omap-for-v3.9-rc1/fixes as 0adcbaf78 > (ARM: OMAP1: Fix build related to kgdb.h no longer including serial_8250.h) > and for lcd_osk.c as omap1_defconfig was broken. > > I don't anything for the first patch you posted, so I suggest > Tomi applies that one. Ok, I'll take the first patch. Tomi
diff --git a/drivers/video/omap/lcd_ams_delta.c b/drivers/video/omap/lcd_ams_delta.c index ed4cad8..4a5f2cd 100644 --- a/drivers/video/omap/lcd_ams_delta.c +++ b/drivers/video/omap/lcd_ams_delta.c @@ -27,6 +27,7 @@ #include <linux/lcd.h> #include <linux/gpio.h> +#include <mach/hardware.h> #include <mach/board-ams-delta.h> #include "omapfb.h"
Fix the following build regression in 3.9-rc1 by including <machine/hardware.h>: drivers/video/omap/lcd_ams_delta.c: In function 'ams_delta_lcd_set_power': drivers/video/omap/lcd_ams_delta.c:48:4: error: implicit declaration of function 'omap_writeb' [-Werror=implicit-function-declaration] drivers/video/omap/lcd_ams_delta.c:49:6: error: 'OMAP_PWL_ENABLE' undeclared (first use in this function) drivers/video/omap/lcd_ams_delta.c:49:6: note: each undeclared identifier is reported only once for each function it appears in drivers/video/omap/lcd_ams_delta.c:50:19: error: 'OMAP_PWL_CLK_ENABLE' undeclared (first use in this function) drivers/video/omap/lcd_ams_delta.c: In function 'ams_delta_lcd_set_contrast': drivers/video/omap/lcd_ams_delta.c:66:22: error: 'OMAP_PWL_ENABLE' undeclared (first use in this function) Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> --- drivers/video/omap/lcd_ams_delta.c | 1 + 1 file changed, 1 insertion(+)