From patchwork Mon Apr 8 11:05:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mohsin Kazmi X-Patchwork-Id: 2407961 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 98DBC3FC71 for ; Mon, 8 Apr 2013 11:13:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762630Ab3DHLNE (ORCPT ); Mon, 8 Apr 2013 07:13:04 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:64285 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759278Ab3DHLND (ORCPT ); Mon, 8 Apr 2013 07:13:03 -0400 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UPA0V-0004zC-5z from Mohsin_Kazmi@mentor.com for linux-fbdev@vger.kernel.org; Mon, 08 Apr 2013 04:13:03 -0700 Received: from pkl-mkazmi-ubuntu.mgc.mentorg.com ([137.202.156.224]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 8 Apr 2013 04:13:03 -0700 From: Mohsin Kazmi To: linux-fbdev@vger.kernel.org Cc: Mohsin Kazmi Subject: [PATCH] of: videomode: Fix module loading problem Date: Mon, 8 Apr 2013 16:05:49 +0500 Message-Id: <1365419149-29581-1-git-send-email-mohsin_kazmi@mentor.com> X-Mailer: git-send-email 1.8.2 X-OriginalArrivalTime: 08 Apr 2013 11:13:03.0671 (UTC) FILETIME=[09C8EC70:01CE344A] Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This patch adds the support load as a module of_videomode.c which is required by parallel display. I have encountered the following problem. imx_parallel_display: Unknown symbol of_get_video_mode (err 0) insmod: can't insert 'imx-parallel-display.ko': unknown symbol in module, or unknown parameter of_get_video_mode() is available in of_videomode.c but it couldn't loaded and gave the following error. of_videomode: Unknown symbol of_property_read_u32_array (err 0) modprobe: can't load module of_videomode (kernel/drivers/of/of_videomode.ko): unknown symbol in module, or unknown parameter I have discussed this with Dmitry Eremin-Solenikov. He told me to do so as in this patch and it works. Signed-off-by: Mohsin Kazmi --- drivers/of/of_videomode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/of/of_videomode.c b/drivers/of/of_videomode.c index 859aefb..cd55f89 100644 --- a/drivers/of/of_videomode.c +++ b/drivers/of/of_videomode.c @@ -10,6 +10,7 @@ #include #include #include +#include int of_get_video_mode(struct device_node *np, struct drm_display_mode *dmode, struct fb_videomode *fbmode) @@ -106,3 +107,5 @@ int of_get_video_mode(struct device_node *np, struct drm_display_mode *dmode, return 0; } EXPORT_SYMBOL_GPL(of_get_video_mode); + +MODULE_LICENSE("GPL");