| Message ID | 1369078578-3138-1-git-send-email-peterhuewe@gmx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 20 May 2013 21:36:18 +0200, Peter Huewe wrote: > Removing some boilerplate by using module_i2c_driver instead of calling > register and unregister in the otherwise empty init/exit functions > > Signed-off-by: Peter Huewe <peterhuewe@gmx.de> > --- > drivers/video/matrox/matroxfb_maven.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c > index 217678e..fd4b64e 100644 > --- a/drivers/video/matrox/matroxfb_maven.c > +++ b/drivers/video/matrox/matroxfb_maven.c > @@ -1283,19 +1283,8 @@ static struct i2c_driver maven_driver={ > .id_table = maven_id, > }; > > -static int __init matroxfb_maven_init(void) > -{ > - return i2c_add_driver(&maven_driver); > -} > - > -static void __exit matroxfb_maven_exit(void) > -{ > - i2c_del_driver(&maven_driver); > -} > - > +module_i2c_driver(maven_driver); > MODULE_AUTHOR("(c) 1999-2002 Petr Vandrovec <vandrove@vc.cvut.cz>"); > MODULE_DESCRIPTION("Matrox G200/G400 Matrox MGA-TVO driver"); > MODULE_LICENSE("GPL"); > -module_init(matroxfb_maven_init); > -module_exit(matroxfb_maven_exit); > /* we do not have __setup() yet */ This last comment could certainly go away as well, AFAICT it's a now meaningless relic. Other than this: Reviewed-by: Jean Delvare <khali@linux-fr.org>
diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c index 217678e..fd4b64e 100644 --- a/drivers/video/matrox/matroxfb_maven.c +++ b/drivers/video/matrox/matroxfb_maven.c @@ -1283,19 +1283,8 @@ static struct i2c_driver maven_driver={ .id_table = maven_id, }; -static int __init matroxfb_maven_init(void) -{ - return i2c_add_driver(&maven_driver); -} - -static void __exit matroxfb_maven_exit(void) -{ - i2c_del_driver(&maven_driver); -} - +module_i2c_driver(maven_driver); MODULE_AUTHOR("(c) 1999-2002 Petr Vandrovec <vandrove@vc.cvut.cz>"); MODULE_DESCRIPTION("Matrox G200/G400 Matrox MGA-TVO driver"); MODULE_LICENSE("GPL"); -module_init(matroxfb_maven_init); -module_exit(matroxfb_maven_exit); /* we do not have __setup() yet */
Removing some boilerplate by using module_i2c_driver instead of calling register and unregister in the otherwise empty init/exit functions Signed-off-by: Peter Huewe <peterhuewe@gmx.de> --- drivers/video/matrox/matroxfb_maven.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-)