From patchwork Tue May 21 12:33:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Laurent Navet [Mali]" X-Patchwork-Id: 2597151 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id D392540077 for ; Tue, 21 May 2013 12:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751689Ab3EUM2J (ORCPT ); Tue, 21 May 2013 08:28:09 -0400 Received: from mail-we0-f181.google.com ([74.125.82.181]:58921 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435Ab3EUM2I (ORCPT ); Tue, 21 May 2013 08:28:08 -0400 Received: by mail-we0-f181.google.com with SMTP id u57so325864wes.40 for ; Tue, 21 May 2013 05:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=y2UZBgk6jKfQKAwQhO4QcM+UW3WXMVr2BRXXOc6sTJc=; b=wQ3mGvRZY9Km+44WyVGBz1/nmL6OtNDRST1rnxTEtASsE9cokEFDNZzrBN1AdntjXc KCutoji/UjfxrsEvOlmAa3WfY5XdyEB8/m73SgV/jta+PZ5puu7hUjlu6OqtClW+oXBD rxZDKGdqtGGDAQNQbijuoPOcfGXYsXHwJ+NnGhHc088jevFYWqqtFiaKOhQj7h+ZHE9h El3MXvd8PUbymW7O23s63wg13fvLxjxNssN1xVGakOVsixMZybTv9YW3dbXqnWhM1aBY A3AqPBVwS8Zd+b0xryskthjkWyk+v+8/ll4O4/ffTDZ8Jga5BML3uPJolOunBPLzEdMv M8Tg== X-Received: by 10.180.90.43 with SMTP id bt11mr4491635wib.30.1369139286988; Tue, 21 May 2013 05:28:06 -0700 (PDT) Received: from localhost.localdomain (ANantes-257-1-177-72.w2-1.abo.wanadoo.fr. [2.1.192.72]) by mx.google.com with ESMTPSA id w8sm30431030wiz.0.2013.05.21.05.28.04 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 May 2013 05:28:05 -0700 (PDT) From: Laurent Navet To: FlorianSchandinat@gmx.de, jg1.han@samsung.com Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Navet Subject: [PATCH V2] drivers: video: mxsfb: clean use of devm_ioremap_resource() Date: Tue, 21 May 2013 14:33:49 +0200 Message-Id: <1369139629-20638-1-git-send-email-laurent.navet@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <19650694.136921368693687337.JavaMail.weblogic@epml12> References: <19650694.136921368693687337.JavaMail.weblogic@epml12> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Check of 'res' and calls to dev_err are already done in devm_ioremap_resource, so no need to do them twice. Signed-off-by: Laurent Navet --- drivers/video/mxsfb.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 21223d4..6a1b338 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -883,12 +883,6 @@ static int mxsfb_probe(struct platform_device *pdev) if (of_id) pdev->id_entry = of_id->data; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "Cannot get memory IO resource\n"); - return -ENODEV; - } - fb_info = framebuffer_alloc(sizeof(struct mxsfb_info), &pdev->dev); if (!fb_info) { dev_err(&pdev->dev, "Failed to allocate fbdev\n"); @@ -897,9 +891,9 @@ static int mxsfb_probe(struct platform_device *pdev) host = to_imxfb_host(fb_info); + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); host->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(host->base)) { - dev_err(&pdev->dev, "ioremap failed\n"); ret = PTR_ERR(host->base); goto fb_release; }