| Message ID | 1369141302.3652.14.camel@clam (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 21, 2013 at 3:01 PM, Geoff Levand <geoff@infradead.org> wrote: > Remove the __initdata attribute from the ps3fb_fix variable. This is in > follow up to the removal of the __devinit attribute on the ps3fb_probe() > routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers: > video: remove __dev* attributes). > > Fixes build warnings like these: > > WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix > The function .ps3fb_probe() references the variable __initdata ps3fb_fix. > This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong. > > Signed-off-by: Geoff Levand <geoff@infradead.org> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 21/05/13 16:01, Geoff Levand wrote: > Remove the __initdata attribute from the ps3fb_fix variable. This is in > follow up to the removal of the __devinit attribute on the ps3fb_probe() > routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers: > video: remove __dev* attributes). > > Fixes build warnings like these: > > WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix > The function .ps3fb_probe() references the variable __initdata ps3fb_fix. > This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong. > > Signed-off-by: Geoff Levand <geoff@infradead.org> > --- > drivers/video/ps3fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c > index a397271d..4819cdf 100644 > --- a/drivers/video/ps3fb.c > +++ b/drivers/video/ps3fb.c > @@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = { > .fb_compat_ioctl = ps3fb_ioctl > }; > > -static struct fb_fix_screeninfo ps3fb_fix __initdata = { > +static struct fb_fix_screeninfo ps3fb_fix = { > .id = DEVICE_NAME, > .type = FB_TYPE_PACKED_PIXELS, > .visual = FB_VISUAL_TRUECOLOR, > Thanks, applied for 3.13. Tomi
On Mon, Sep 16, 2013 at 11:20 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > On 21/05/13 16:01, Geoff Levand wrote: >> Remove the __initdata attribute from the ps3fb_fix variable. This is in >> follow up to the removal of the __devinit attribute on the ps3fb_probe() >> routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers: >> video: remove __dev* attributes). >> >> Fixes build warnings like these: >> >> WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix >> The function .ps3fb_probe() references the variable __initdata ps3fb_fix. >> This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong. >> >> Signed-off-by: Geoff Levand <geoff@infradead.org> > > Thanks, applied for 3.13. Too late. It already got in last week through Cell and PS3 supporter BenH ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 16/09/13 12:28, Geert Uytterhoeven wrote: > On Mon, Sep 16, 2013 at 11:20 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: >> On 21/05/13 16:01, Geoff Levand wrote: >>> Remove the __initdata attribute from the ps3fb_fix variable. This is in >>> follow up to the removal of the __devinit attribute on the ps3fb_probe() >>> routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers: >>> video: remove __dev* attributes). >>> >>> Fixes build warnings like these: >>> >>> WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix >>> The function .ps3fb_probe() references the variable __initdata ps3fb_fix. >>> This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong. >>> >>> Signed-off-by: Geoff Levand <geoff@infradead.org> >> >> Thanks, applied for 3.13. > > Too late. It already got in last week through Cell and PS3 supporter BenH ;-) Ok, thanks for informing. Maybe I'll be faster next time, shouldn't be difficult to achieve ;). Tomi
diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c index a397271d..4819cdf 100644 --- a/drivers/video/ps3fb.c +++ b/drivers/video/ps3fb.c @@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = { .fb_compat_ioctl = ps3fb_ioctl }; -static struct fb_fix_screeninfo ps3fb_fix __initdata = { +static struct fb_fix_screeninfo ps3fb_fix = { .id = DEVICE_NAME, .type = FB_TYPE_PACKED_PIXELS, .visual = FB_VISUAL_TRUECOLOR,
Remove the __initdata attribute from the ps3fb_fix variable. This is in follow up to the removal of the __devinit attribute on the ps3fb_probe() routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers: video: remove __dev* attributes). Fixes build warnings like these: WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable __initdata ps3fb_fix. This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong. Signed-off-by: Geoff Levand <geoff@infradead.org> --- drivers/video/ps3fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)