From patchwork Tue May 21 13:01:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geoff Levand X-Patchwork-Id: 2597251 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 7EF0BDFB79 for ; Tue, 21 May 2013 13:02:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754220Ab3EUNCE (ORCPT ); Tue, 21 May 2013 09:02:04 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:50689 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753886Ab3EUNCD (ORCPT ); Tue, 21 May 2013 09:02:03 -0400 Received: from [120.193.5.254] (helo=[192.168.88.13]) by bombadil.infradead.org with esmtpsa (Exim 4.80.1 #2 (Red Hat Linux)) id 1UemCN-0005OV-8a; Tue, 21 May 2013 13:01:51 +0000 Message-ID: <1369141302.3652.14.camel@clam> Subject: [PATCH] video/ps3fb: Fix section mismatch warning From: Geoff Levand To: Florian Tobias Schandinat Cc: linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Geert Uytterhoeven Date: Tue, 21 May 2013 21:01:42 +0800 X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Remove the __initdata attribute from the ps3fb_fix variable. This is in follow up to the removal of the __devinit attribute on the ps3fb_probe() routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers: video: remove __dev* attributes). Fixes build warnings like these: WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable __initdata ps3fb_fix. This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong. Signed-off-by: Geoff Levand Acked-by: Geert Uytterhoeven --- drivers/video/ps3fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c index a397271d..4819cdf 100644 --- a/drivers/video/ps3fb.c +++ b/drivers/video/ps3fb.c @@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = { .fb_compat_ioctl = ps3fb_ioctl }; -static struct fb_fix_screeninfo ps3fb_fix __initdata = { +static struct fb_fix_screeninfo ps3fb_fix = { .id = DEVICE_NAME, .type = FB_TYPE_PACKED_PIXELS, .visual = FB_VISUAL_TRUECOLOR,