| Message ID | 1371476589-4660-1-git-send-email-fabio.estevam@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10:43 Mon 17 Jun , Fabio Estevam wrote: > Commit ffa3fd21de ("videomode: implement public of_get_display_timing()") causes > the following build warning: > > include/video/of_display_timing.h:18:10: warning: 'struct display_timing' declared inside parameter list [enabled by default] > include/video/of_display_timing.h:18:10: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] > > As 'struct display_timing' is defined at <video/display_timing.h>, let's include > this header to avoid the warning. for 3.10 or 3.11? Best Regards, J. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > include/video/of_display_timing.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/video/of_display_timing.h b/include/video/of_display_timing.h > index 6562ad9..a136f58 100644 > --- a/include/video/of_display_timing.h > +++ b/include/video/of_display_timing.h > @@ -8,6 +8,7 @@ > > #ifndef __LINUX_OF_DISPLAY_TIMING_H > #define __LINUX_OF_DISPLAY_TIMING_H > +#include <video/display_timing.h> > > struct device_node; > struct display_timings; > -- > 1.8.1.2 > > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jun 17, 2013 at 1:09 PM, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote: > On 10:43 Mon 17 Jun , Fabio Estevam wrote: >> Commit ffa3fd21de ("videomode: implement public of_get_display_timing()") causes >> the following build warning: >> >> include/video/of_display_timing.h:18:10: warning: 'struct display_timing' declared inside parameter list [enabled by default] >> include/video/of_display_timing.h:18:10: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] >> >> As 'struct display_timing' is defined at <video/display_timing.h>, let's include >> this header to avoid the warning. > for 3.10 or 3.11? This is 3.11 material. -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 17/06/13 16:43, Fabio Estevam wrote: > Commit ffa3fd21de ("videomode: implement public of_get_display_timing()") causes > the following build warning: > > include/video/of_display_timing.h:18:10: warning: 'struct display_timing' declared inside parameter list [enabled by default] > include/video/of_display_timing.h:18:10: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] > > As 'struct display_timing' is defined at <video/display_timing.h>, let's include > this header to avoid the warning. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > include/video/of_display_timing.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/video/of_display_timing.h b/include/video/of_display_timing.h > index 6562ad9..a136f58 100644 > --- a/include/video/of_display_timing.h > +++ b/include/video/of_display_timing.h > @@ -8,6 +8,7 @@ > > #ifndef __LINUX_OF_DISPLAY_TIMING_H > #define __LINUX_OF_DISPLAY_TIMING_H > +#include <video/display_timing.h> > > struct device_node; > struct display_timings; > We don't need to include display_timing.h, we can just add: struct display_timing; Tomi
diff --git a/include/video/of_display_timing.h b/include/video/of_display_timing.h index 6562ad9..a136f58 100644 --- a/include/video/of_display_timing.h +++ b/include/video/of_display_timing.h @@ -8,6 +8,7 @@ #ifndef __LINUX_OF_DISPLAY_TIMING_H #define __LINUX_OF_DISPLAY_TIMING_H +#include <video/display_timing.h> struct device_node; struct display_timings;
Commit ffa3fd21de ("videomode: implement public of_get_display_timing()") causes the following build warning: include/video/of_display_timing.h:18:10: warning: 'struct display_timing' declared inside parameter list [enabled by default] include/video/of_display_timing.h:18:10: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] As 'struct display_timing' is defined at <video/display_timing.h>, let's include this header to avoid the warning. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- include/video/of_display_timing.h | 1 + 1 file changed, 1 insertion(+)