From patchwork Fri Jun 28 13:43:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 2799241 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 91E32BF4A1 for ; Fri, 28 Jun 2013 13:44:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5FC2A20188 for ; Fri, 28 Jun 2013 13:44:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F103A20186 for ; Fri, 28 Jun 2013 13:44:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754606Ab3F1Noy (ORCPT ); Fri, 28 Jun 2013 09:44:54 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:61811 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262Ab3F1Nox (ORCPT ); Fri, 28 Jun 2013 09:44:53 -0400 Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MP300E9SVIGYOI0@mailout4.samsung.com>; Fri, 28 Jun 2013 22:44:52 +0900 (KST) X-AuditID: cbfee61b-b7f8e6d00000524c-68-51cd93532c30 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 06.46.21068.3539DC15; Fri, 28 Jun 2013 22:44:51 +0900 (KST) Received: from amdc1344.digital.local ([106.116.147.32]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MP300GFHVG1GY60@mmp1.samsung.com>; Fri, 28 Jun 2013 22:44:51 +0900 (KST) From: Sylwester Nawrocki To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: kishon@ti.com, linux-media@vger.kernel.org, kyungmin.park@samsung.com, balbi@ti.com, t.figa@samsung.com, devicetree-discuss@lists.ozlabs.org, kgene.kim@samsung.com, dh09.lee@samsung.com, jg1.han@samsung.com, inki.dae@samsung.com, tomi.valkeinen@ti.com, plagnioj@jcrosoft.com, jason77.wang@gmail.com, linux-fbdev@vger.kernel.org, Sylwester Nawrocki Subject: [PATCH v4 4/5] [media] exynos4-is: Use the generic MIPI CSIS PHY driver Date: Fri, 28 Jun 2013 15:43:10 +0200 Message-id: <1372426991-2482-5-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1372426991-2482-1-git-send-email-s.nawrocki@samsung.com> References: <1372426991-2482-1-git-send-email-s.nawrocki@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t9jAd3gyWcDDTYeMbc4eL/e4sDsh6wW 18/bWUy6P4HFYsbSR6wWlxdeYrXoXXCVzeLC0x42i7NNb9gtNj2+xmpxou8Dq0XPhq2sFjPO 72OyWPfwBZPF4TftrBbrZ7xmsVg//xabg6DHzll32T1eXbjD4rF5Sb3H+RkLGT36tqxi9Dh+ YzuTx+dNcgHsUVw2Kak5mWWpRfp2CVwZuz5+YCxoUKyY1vKTvYHxj1QXIyeHhICJxPPr9xkh bDGJC/fWs3UxcnEICSxilDg9+wKU08EkMe3hWWaQKjYBQ4neo31AHRwcIgLeEsuvKYLUMAs0 MUu0zl7GClIjLBAgsfv0QxYQm0VAVWLmnhNgNq+Aq8SZ7fvYQHolBBQk5kyyAQlzCrhJvHrQ yw5iCwGVLH7yhGkCI+8CRoZVjKKpBckFxUnpuUZ6xYm5xaV56XrJ+bmbGMFh/Ex6B+OqBotD jAIcjEo8vA2JZwKFWBPLiitzDzFKcDArifAennA2UIg3JbGyKrUoP76oNCe1+BCjNAeLkjjv wVbrQCGB9MSS1OzU1ILUIpgsEwenVAMj/9zsiW66Ty5Omvtyw+f1CYqbPvwqmaahKLtzyvbI Nf7MLHml20/Mvito+MhhTXxep2xDUYfxW65Nhld+sO3hTjBriS3ct/1E5u0dt3I4amzXbr1h dvvCgqaLvr9usPpXCO3bz3s86+ukpJWvPNI2y839urL73aSXcsZ7I9um8baVRu29tmf/CiWW 4oxEQy3mouJEABipPJhfAgAA Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use the generic PHY API instead of the platform callback to control the MIPI CSIS DPHY. The 'phy_label' field is added to the platform data structure to allow PHY lookup on non-dt platforms Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi Acked-by: Mauro Carvalho Chehab --- drivers/media/platform/exynos4-is/mipi-csis.c | 16 +++++++++++++--- include/linux/platform_data/mipi-csis.h | 11 ++--------- 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c b/drivers/media/platform/exynos4-is/mipi-csis.c index a2eda9d..8436254 100644 --- a/drivers/media/platform/exynos4-is/mipi-csis.c +++ b/drivers/media/platform/exynos4-is/mipi-csis.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include @@ -167,6 +168,7 @@ struct csis_pktbuf { * @sd: v4l2_subdev associated with CSIS device instance * @index: the hardware instance index * @pdev: CSIS platform device + * @phy: pointer to the CSIS generic PHY * @regs: mmaped I/O registers memory * @supplies: CSIS regulator supplies * @clock: CSIS clocks @@ -189,6 +191,8 @@ struct csis_state { struct v4l2_subdev sd; u8 index; struct platform_device *pdev; + struct phy *phy; + const char *phy_label; void __iomem *regs; struct regulator_bulk_data supplies[CSIS_NUM_SUPPLIES]; struct clk *clock[NUM_CSIS_CLOCKS]; @@ -726,6 +730,7 @@ static int s5pcsis_get_platform_data(struct platform_device *pdev, state->index = max(0, pdev->id); state->max_num_lanes = state->index ? CSIS1_MAX_LANES : CSIS0_MAX_LANES; + state->phy_label = pdata->phy_label; return 0; } @@ -763,8 +768,9 @@ static int s5pcsis_parse_dt(struct platform_device *pdev, "samsung,csis-wclk"); state->num_lanes = endpoint.bus.mipi_csi2.num_data_lanes; - of_node_put(node); + + state->phy_label = "csis"; return 0; } #else @@ -800,6 +806,10 @@ static int s5pcsis_probe(struct platform_device *pdev) return -EINVAL; } + state->phy = devm_phy_get(dev, state->phy_label); + if (IS_ERR(state->phy)) + return PTR_ERR(state->phy); + mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); state->regs = devm_ioremap_resource(dev, mem_res); if (IS_ERR(state->regs)) @@ -893,7 +903,7 @@ static int s5pcsis_pm_suspend(struct device *dev, bool runtime) mutex_lock(&state->lock); if (state->flags & ST_POWERED) { s5pcsis_stop_stream(state); - ret = s5p_csis_phy_enable(state->index, false); + ret = phy_power_off(state->phy); if (ret) goto unlock; ret = regulator_bulk_disable(CSIS_NUM_SUPPLIES, @@ -929,7 +939,7 @@ static int s5pcsis_pm_resume(struct device *dev, bool runtime) state->supplies); if (ret) goto unlock; - ret = s5p_csis_phy_enable(state->index, true); + ret = phy_power_on(state->phy); if (!ret) { state->flags |= ST_POWERED; } else { diff --git a/include/linux/platform_data/mipi-csis.h b/include/linux/platform_data/mipi-csis.h index bf34e17..9214317 100644 --- a/include/linux/platform_data/mipi-csis.h +++ b/include/linux/platform_data/mipi-csis.h @@ -17,21 +17,14 @@ * @wclk_source: CSI wrapper clock selection: 0 - bus clock, 1 - ext. SCLK_CAM * @lanes: number of data lanes used * @hs_settle: HS-RX settle time + * @phy_label: the generic PHY label */ struct s5p_platform_mipi_csis { unsigned long clk_rate; u8 wclk_source; u8 lanes; u8 hs_settle; + const char *phy_label; }; -/** - * s5p_csis_phy_enable - global MIPI-CSI receiver D-PHY control - * @id: MIPI-CSIS harware instance index (0...1) - * @on: true to enable D-PHY and deassert its reset - * false to disable D-PHY - * @return: 0 on success, or negative error code on failure - */ -int s5p_csis_phy_enable(int id, bool on); - #endif /* __PLAT_SAMSUNG_MIPI_CSIS_H_ */