| Message ID | 1373923884-13332-1-git-send-email-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 15 Jul 2013 18:31:24 -0300 Fabio Estevam <festevam@gmail.com> wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Since commit ab78029 (drivers/pinctrl: grab default handles from device core) > we can rely on device core for handling pinctrl, so remove > devm_pinctrl_get_select_default() from the driver. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > Acked-by: Shawn Guo <shawn.guo@linaro.org> > --- > Andrew, > > Should this go via your tree? Well, no, it should really be reviewed by and merged by Jean-Christophe. Is there a problem in fbdev land? -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 16/07/13 00:31, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Since commit ab78029 (drivers/pinctrl: grab default handles from device core) > we can rely on device core for handling pinctrl, so remove > devm_pinctrl_get_select_default() from the driver. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > Acked-by: Shawn Guo <shawn.guo@linaro.org> Thanks, I've applied this into my 3.12/fbdev branch. Tomi
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index 21223d4..9d6a286 100644 --- a/drivers/video/mxsfb.c +++ b/drivers/video/mxsfb.c @@ -46,7 +46,6 @@ #include <linux/clk.h> #include <linux/dma-mapping.h> #include <linux/io.h> -#include <linux/pinctrl/consumer.h> #include <linux/fb.h> #include <linux/regulator/consumer.h> #include <video/of_display_timing.h> @@ -877,7 +876,6 @@ static int mxsfb_probe(struct platform_device *pdev) struct mxsfb_info *host; struct fb_info *fb_info; struct fb_modelist *modelist; - struct pinctrl *pinctrl; int ret; if (of_id) @@ -909,12 +907,6 @@ static int mxsfb_probe(struct platform_device *pdev) host->devdata = &mxsfb_devdata[pdev->id_entry->driver_data]; - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); - if (IS_ERR(pinctrl)) { - ret = PTR_ERR(pinctrl); - goto fb_release; - } - host->clk = devm_clk_get(&host->pdev->dev, NULL); if (IS_ERR(host->clk)) { ret = PTR_ERR(host->clk);