From patchwork Fri Aug 23 18:17:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Etheridge, Darren" X-Patchwork-Id: 2848972 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F3A4EBF546 for ; Fri, 23 Aug 2013 18:22:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BBFCB20450 for ; Fri, 23 Aug 2013 18:22:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62AD42047B for ; Fri, 23 Aug 2013 18:22:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756092Ab3HWSWE (ORCPT ); Fri, 23 Aug 2013 14:22:04 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:51828 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756088Ab3HWSWC (ORCPT ); Fri, 23 Aug 2013 14:22:02 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id r7NILwqS015491; Fri, 23 Aug 2013 13:21:58 -0500 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id r7NILwBN029801; Fri, 23 Aug 2013 13:21:58 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.2.342.3; Fri, 23 Aug 2013 13:21:58 -0500 Received: from localhost.localdomain (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id r7NILfNn018405; Fri, 23 Aug 2013 13:21:58 -0500 From: Darren Etheridge To: , , , , , CC: Subject: [PATCH v3 1/1] video: da8xx-fb: adding dt support Date: Fri, 23 Aug 2013 13:17:02 -0500 Message-ID: <1377281822-29659-2-git-send-email-detheridge@ti.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1377281822-29659-1-git-send-email-detheridge@ti.com> References: <1377281822-29659-1-git-send-email-detheridge@ti.com> MIME-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Enhancing driver to enable probe triggered by a corresponding dt entry. Add da8xx-fb.txt documentation to devicetree section. Obtain fb_videomode details for the connected lcd panel using the display timing details present in DT. Ensure that platform data is present before checking whether platform callback is present (the one used to control backlight). So far this was not an issue as driver was purely non-DT triggered, but now DT support has been added this check must be performed. v2: squashing multiple commits from Afzal Mohammed (afzal@ti.com) v3: remove superfluous cast v4: expose both ti,am3352-lcdc and ti,da830-lcdc for .compatible as driver can use enhanced features of all version of the silicon block. v5: addressed review comments from Prabhakar Lad v6: Changed the .compatible naming to match the existing drm bindings for am33xx devices v7: clarify which compatible to use in the documentation for DA850 Acked-by: Lad, Prabhakar Signed-off-by: Darren Etheridge --- .../devicetree/bindings/video/da8xx-fb.txt | 42 ++++++++++++ drivers/video/da8xx-fb.c | 66 +++++++++++++++++++- 2 files changed, 105 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/video/da8xx-fb.txt diff --git a/Documentation/devicetree/bindings/video/da8xx-fb.txt b/Documentation/devicetree/bindings/video/da8xx-fb.txt new file mode 100644 index 0000000..d86afe7 --- /dev/null +++ b/Documentation/devicetree/bindings/video/da8xx-fb.txt @@ -0,0 +1,42 @@ +TI LCD Controller on DA830/DA850/AM335x SoC's + +Required properties: +- compatible: + DA830, DA850 - "ti,da8xx-tilcdc" + AM335x SoC's - "ti,am33xx-tilcdc" +- reg: Address range of lcdc register set +- interrupts: lcdc interrupt +- display-timings: typical videomode of lcd panel, represented as child. + Refer Documentation/devicetree/bindings/video/display-timing.txt for + display timing binding details. If multiple videomodes are mentioned + in display timings node, typical videomode has to be mentioned as the + native mode or it has to be first child (driver cares only for native + videomode). + +Recommended properties: +- ti,hwmods: Name of the hwmod associated to the LCDC + +Example for am335x SoC's: + +lcdc@4830e000 { + compatible = "ti,am33xx-tilcdc"; + reg = <0x4830e000 0x1000>; + interrupts = <36>; + ti,hwmods = "lcdc"; + status = "okay"; + display-timings { + 800x480p62 { + clock-frequency = <30000000>; + hactive = <800>; + vactive = <480>; + hfront-porch = <39>; + hback-porch = <39>; + hsync-len = <47>; + vback-porch = <29>; + vfront-porch = <13>; + vsync-len = <2>; + hsync-active = <1>; + vsync-active = <1>; + }; + }; +}; diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c index ea9771f..1d9aff1 100644 --- a/drivers/video/da8xx-fb.c +++ b/drivers/video/da8xx-fb.c @@ -36,6 +36,7 @@ #include #include #include +#include