From patchwork Tue Sep 10 21:59:43 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geoff Levand X-Patchwork-Id: 2867871 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 916CF9F2D6 for ; Tue, 10 Sep 2013 21:59:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BD65E20220 for ; Tue, 10 Sep 2013 21:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBD852021E for ; Tue, 10 Sep 2013 21:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751081Ab3IJV7u (ORCPT ); Tue, 10 Sep 2013 17:59:50 -0400 Received: from merlin.infradead.org ([205.233.59.134]:58182 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954Ab3IJV7u (ORCPT ); Tue, 10 Sep 2013 17:59:50 -0400 Received: from 107-1-141-74-ip-static.hfc.comcastbusiness.net ([107.1.141.74] helo=[192.168.254.170]) by merlin.infradead.org with esmtpsa (Exim 4.80.1 #2 (Red Hat Linux)) id 1VJVyO-0002xD-E7; Tue, 10 Sep 2013 21:59:48 +0000 Message-ID: <1378850383.19147.27.camel@smoke> Subject: [PATCH] video/ps3fb: Fix section mismatch warning From: Geoff Levand To: Florian Tobias Schandinat Cc: linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Geert Uytterhoeven , Vladimir Murzin Date: Tue, 10 Sep 2013 14:59:43 -0700 In-Reply-To: <1369141302.3652.14.camel@clam> References: <1369141302.3652.14.camel@clam> X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove the __initdata attribute from the ps3fb_fix variable. This is in follow up to the removal of the __devinit attribute on the ps3fb_probe() routine in commit 48c68c4f1b542444f175a9e136febcecf3e704d8 (Drivers: video: remove __dev* attributes). Fixes build warnings like these: WARNING: vmlinux.o Section mismatch in reference from the function .ps3fb_probe() to the variable .init.data:ps3fb_fix The function .ps3fb_probe() references the variable __initdata ps3fb_fix. This is often because .ps3fb_probe lacks a __initdata annotation or the annotation of ps3fb_fix is wrong. Signed-off-by: Geoff Levand Reviewed-by: Jingoo Han --- This is a re-send. Could we please get this applied. -Geoff drivers/video/ps3fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/ps3fb.c b/drivers/video/ps3fb.c index a397271d..4819cdf 100644 --- a/drivers/video/ps3fb.c +++ b/drivers/video/ps3fb.c @@ -952,7 +952,7 @@ static struct fb_ops ps3fb_ops = { .fb_compat_ioctl = ps3fb_ioctl }; -static struct fb_fix_screeninfo ps3fb_fix __initdata = { +static struct fb_fix_screeninfo ps3fb_fix = { .id = DEVICE_NAME, .type = FB_TYPE_PACKED_PIXELS, .visual = FB_VISUAL_TRUECOLOR,