diff mbox

[04/15] video: mb862xx: Remove redundant dev_set_drvdata

Message ID 1379658744-17113-5-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat Sept. 20, 2013, 6:32 a.m. UTC
Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Anatolij Gustschin <agust@denx.de>
---
 drivers/video/mb862xx/mb862xxfbdrv.c |    2 --
 1 file changed, 2 deletions(-)

Comments

Anatolij Gustschin Sept. 21, 2013, 8:37 a.m. UTC | #1
On Fri, 20 Sep 2013 12:02:13 +0530
Sachin Kamat <sachin.kamat@linaro.org> wrote:

> Driver core sets driver data to NULL upon failure or remove.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Anatolij Gustschin <agust@denx.de>

Acked-by: Anatolij Gustschin <agust@denx.de>

> ---
>  drivers/video/mb862xx/mb862xxfbdrv.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/video/mb862xx/mb862xxfbdrv.c b/drivers/video/mb862xx/mb862xxfbdrv.c
> index 98d2f8c..0cd4c33 100644
> --- a/drivers/video/mb862xx/mb862xxfbdrv.c
> +++ b/drivers/video/mb862xx/mb862xxfbdrv.c
> @@ -781,7 +781,6 @@ rel_reg:
>  irqdisp:
>  	irq_dispose_mapping(par->irq);
>  fbrel:
> -	dev_set_drvdata(dev, NULL);
>  	framebuffer_release(info);
>  	return ret;
>  }
> @@ -814,7 +813,6 @@ static int of_platform_mb862xx_remove(struct platform_device *ofdev)
>  	iounmap(par->mmio_base);
>  	iounmap(par->fb_base);
>  
> -	dev_set_drvdata(&ofdev->dev, NULL);
>  	release_mem_region(par->res->start, res_size);
>  	framebuffer_release(fbi);
>  	return 0;


--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/video/mb862xx/mb862xxfbdrv.c b/drivers/video/mb862xx/mb862xxfbdrv.c
index 98d2f8c..0cd4c33 100644
--- a/drivers/video/mb862xx/mb862xxfbdrv.c
+++ b/drivers/video/mb862xx/mb862xxfbdrv.c
@@ -781,7 +781,6 @@  rel_reg:
 irqdisp:
 	irq_dispose_mapping(par->irq);
 fbrel:
-	dev_set_drvdata(dev, NULL);
 	framebuffer_release(info);
 	return ret;
 }
@@ -814,7 +813,6 @@  static int of_platform_mb862xx_remove(struct platform_device *ofdev)
 	iounmap(par->mmio_base);
 	iounmap(par->fb_base);
 
-	dev_set_drvdata(&ofdev->dev, NULL);
 	release_mem_region(par->res->start, res_size);
 	framebuffer_release(fbi);
 	return 0;