diff mbox

[1/2] backlight: l4f00242t03: Remove redundant spi_set_drvdata

Message ID 1379659133-18799-1-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat Sept. 20, 2013, 6:38 a.m. UTC
Driver core sets driver data to NULL upon failure or remove.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/video/backlight/l4f00242t03.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Jingoo Han Sept. 24, 2013, 5:40 a.m. UTC | #1
On Friday, September 20, 2013 3:39 PM, Sachin Kamat wrote:
> 
> Driver core sets driver data to NULL upon failure or remove.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>

Acked-by: Jingoo Han <jg1.han@samsung.com>

It looks good.
Thank you for sending the patch.

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tomi Valkeinen Sept. 26, 2013, 8:48 a.m. UTC | #2
On 20/09/13 09:38, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/video/backlight/l4f00242t03.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
> index a35a38c..59eebe0 100644
> --- a/drivers/video/backlight/l4f00242t03.c
> +++ b/drivers/video/backlight/l4f00242t03.c
> @@ -244,7 +244,6 @@ static int l4f00242t03_remove(struct spi_device *spi)
>  
>  	l4f00242t03_lcd_power_set(priv->ld, FB_BLANK_POWERDOWN);
>  	lcd_device_unregister(priv->ld);
> -	spi_set_drvdata(spi, NULL);
>  
>  	return 0;
>  }
> 

Thanks, queuing this and the second patch for 3.13.

 Tomi
Jingoo Han Sept. 27, 2013, 12:08 a.m. UTC | #3
On Thursday, September 26, 2013 5:48 PM, Tomi Valkeinen wrote:
> On 20/09/13 09:38, Sachin Kamat wrote:
> > Driver core sets driver data to NULL upon failure or remove.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> >  drivers/video/backlight/l4f00242t03.c |    1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
> > index a35a38c..59eebe0 100644
> > --- a/drivers/video/backlight/l4f00242t03.c
> > +++ b/drivers/video/backlight/l4f00242t03.c
> > @@ -244,7 +244,6 @@ static int l4f00242t03_remove(struct spi_device *spi)
> >
> >  	l4f00242t03_lcd_power_set(priv->ld, FB_BLANK_POWERDOWN);
> >  	lcd_device_unregister(priv->ld);
> > -	spi_set_drvdata(spi, NULL);
> >
> >  	return 0;
> >  }
> >
> 
> Thanks, queuing this and the second patch for 3.13.
> 

Hi Tomi Valkeinen,

Andrew Morton already merged these patches to mm-tree with my Acked-by.
So, you don't need to queue these patches.
Thank you for caring. :-)

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
index a35a38c..59eebe0 100644
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -244,7 +244,6 @@  static int l4f00242t03_remove(struct spi_device *spi)
 
 	l4f00242t03_lcd_power_set(priv->ld, FB_BLANK_POWERDOWN);
 	lcd_device_unregister(priv->ld);
-	spi_set_drvdata(spi, NULL);
 
 	return 0;
 }