From patchwork Thu Sep 26 11:59:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2948141 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DD3D3BFF05 for ; Thu, 26 Sep 2013 11:59:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CACC120279 for ; Thu, 26 Sep 2013 11:59:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B46C20278 for ; Thu, 26 Sep 2013 11:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756524Ab3IZL7l (ORCPT ); Thu, 26 Sep 2013 07:59:41 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:48786 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755712Ab3IZL7l (ORCPT ); Thu, 26 Sep 2013 07:59:41 -0400 Received: by mail-pa0-f45.google.com with SMTP id rd3so1213688pab.4 for ; Thu, 26 Sep 2013 04:59:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=B2+lbJttuOwrep+gEEc1Mm8mRNkqVOKojyfgAapGl6s=; b=AuQA/Jac+++P3mdaw1GamWKPcjKduk+D9whXiZNM/g0k/4CYHbFSuN/9AaQ024Wrl5 C7D3AJzhqBjphMK3YK2f4rZk8/jqBIIch8+FeK2kXG3jRa9dv4ZpJ0uwv7s8dk1wa7xC 7+q5f0eIszXSIl+jp8ptb/aQjx1/LoCyWhgbecGDb1szQVoENdnIrM93kJgqZG5n3j+b 0AMsTNQ2h7WesLLqW7lVTH71PG+Z+ULMY1PK2bfWLapHMRCpLIZBKmKwjZD3XTJnBy5C P2sgJQZq/ak7L3gpswV/ApwBQDNikAbW4+sBc665DwIFWHwn3BABI4YnwFGVkx50bqCk bAsA== X-Gm-Message-State: ALoCoQkFqhn8YbuGI5TB2lFXDyQmQ0ZPA4l+vTBEMdNY7NqmBZgWPayNxFyfBJLmzqyYq/+dGBk7 X-Received: by 10.66.235.106 with SMTP id ul10mr4737771pac.19.1380196780912; Thu, 26 Sep 2013 04:59:40 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id gh2sm1759127pbc.40.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Sep 2013 04:59:40 -0700 (PDT) From: Sachin Kamat To: linux-fbdev@vger.kernel.org Cc: tomi.valkeinen@ti.com, plagnioj@jcrosoft.com, jg1.han@samsung.com, akpm@linux-foundation.org, sachin.kamat@linaro.org, Daniel Jeong Subject: [PATCH 1/1] backlight: lm3630a_bl: Fix incorrect variable type Date: Thu, 26 Sep 2013 17:29:36 +0530 Message-Id: <1380196776-27909-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 'lm3630a_read' returns a negative error code upon failure. This will never get detected by unsigned 'rval'. Make it signed. Signed-off-by: Sachin Kamat Cc: Daniel Jeong --- drivers/video/backlight/lm3630a_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index c63f918..65392f9 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip) /* interrupt handling */ static void lm3630a_delayed_func(struct work_struct *work) { - unsigned int rval; + int rval; struct lm3630a_chip *pchip; pchip = container_of(work, struct lm3630a_chip, work.work);