From patchwork Wed Oct 2 14:58:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Herrmann X-Patchwork-Id: 2975631 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CD8359F245 for ; Wed, 2 Oct 2013 14:59:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3A2EF20306 for ; Wed, 2 Oct 2013 14:59:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A22720303 for ; Wed, 2 Oct 2013 14:59:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753736Ab3JBO66 (ORCPT ); Wed, 2 Oct 2013 10:58:58 -0400 Received: from mail-ee0-f51.google.com ([74.125.83.51]:41659 "EHLO mail-ee0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753593Ab3JBO65 (ORCPT ); Wed, 2 Oct 2013 10:58:57 -0400 Received: by mail-ee0-f51.google.com with SMTP id c1so456075eek.38 for ; Wed, 02 Oct 2013 07:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HSwqk6B3ZhbFGeqjhFdeQfllnLQqHd6lLSxQJbvGru8=; b=CnlIp/HvQ698MKsY1/4M/YRfoHL7DA88QFiqFNnWiWWq2Os6FS8OZsWjDKp6b/IBBd 2XxiNKKxwEU8kq2WfNscz8UFMV8r54XTm656mgKPbaD2o6oX1wfdopLUVIW/8zQ6LnwB 4j5zTkKJjustg7AK4LwrQhVCrQQivW7N4VLBLy4IvImHdaUiEigWngzaSpDUKPpjMIwS mJlmBrM84KFBx/NWdvGgclozV1ua/SSg+Iv1sUTtUOlgNkRODFQHLhX057xvwH4m9XMp z+rC2MH6DY3Ec86kRZhvdDN3oHRS+mWp0K+plKpI8VfwUbU8dlHpEBICECLsx+dcaUKF 310A== X-Received: by 10.14.241.74 with SMTP id f50mr4273876eer.29.1380725936374; Wed, 02 Oct 2013 07:58:56 -0700 (PDT) Received: from localhost.localdomain (stgt-5f71b885.pool.mediaWays.net. [95.113.184.133]) by mx.google.com with ESMTPSA id z12sm4675926eev.6.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 02 Oct 2013 07:58:55 -0700 (PDT) From: David Herrmann To: linux-fbdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Tom Gundersen , Alexandre Courbot , Stephen Warren , dri-devel@lists.freedesktop.org, Jean-Christophe Plagniol-Villard , Tomi Valkeinen , David Herrmann Subject: [PATCH 2/2] simplefb: use write-combined remapping Date: Wed, 2 Oct 2013 16:58:39 +0200 Message-Id: <1380725919-1961-2-git-send-email-dh.herrmann@gmail.com> X-Mailer: git-send-email 1.8.4 In-Reply-To: <1380725919-1961-1-git-send-email-dh.herrmann@gmail.com> References: <1380725919-1961-1-git-send-email-dh.herrmann@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Framebuffers shouldn't be cached and it is usually very uncommon to read them. Therefore, use ioremap_wc() to get significant speed improvements on systems which provide it. On all other systems it's aliased to ioremap_nocache() which is also fine. Reported-by: Tom Gundersen Signed-off-by: David Herrmann Tested-by: Tom Gundersen Tested-by: Alexandre Courbot Tested-by: Stephen Warren --- drivers/video/simplefb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c index 74b016c..64db54a 100644 --- a/drivers/video/simplefb.c +++ b/drivers/video/simplefb.c @@ -219,8 +219,8 @@ static int simplefb_probe(struct platform_device *pdev) info->fbops = &simplefb_ops; info->flags = FBINFO_DEFAULT | FBINFO_MISC_FIRMWARE; - info->screen_base = ioremap(info->fix.smem_start, - info->fix.smem_len); + info->screen_base = ioremap_wc(info->fix.smem_start, + info->fix.smem_len); if (!info->screen_base) { framebuffer_release(info); return -ENODEV;