From patchwork Fri Jan 17 11:00:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 3503581 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 820E0C02DC for ; Fri, 17 Jan 2014 11:04:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 78C2C20170 for ; Fri, 17 Jan 2014 11:04:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7018720165 for ; Fri, 17 Jan 2014 11:04:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751326AbaAQLEf (ORCPT ); Fri, 17 Jan 2014 06:04:35 -0500 Received: from mail-pd0-f180.google.com ([209.85.192.180]:40960 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974AbaAQLEe (ORCPT ); Fri, 17 Jan 2014 06:04:34 -0500 Received: by mail-pd0-f180.google.com with SMTP id x10so2582484pdj.11 for ; Fri, 17 Jan 2014 03:04:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=49nE/mS+5SD7/EfxhP7pjMO3E6KZW1a8kScC8YyqZx4=; b=OzpIxxCs67e2mvARcWxfblGZYHOaft0fAVInAPnujNx+mfdwX5vExIedZAJQ0yhpzR 5Sqe967FQpvmvwWFTCmNk0UiOMCBpCMlCEdCx9zLVNwaPW9mT9mceDkrxnGq6z0gRq2k FkU1Ynhdy1y0tOa088ao34cO32tFbhCSsUoRxDgbL9l20/EDGQ4qddWhWiAg+fWgDY+Z JdTiMR+Zlx0qajgw35r3n3ZrM6lvxZfmev7nVNcTGlHDh+sZq1LnKGZEi4Nv8ziTaVVp xLrN5UWpfCvwS1tYmxiMHAWq6Kkai5NBG0Pj4JtGXUX3aET8A1dRWEcVOTYT1ikubtGD bDnw== X-Gm-Message-State: ALoCoQkXrdhWbV33WJP8ytMQadIpoJSHVwTEASM9wOf0G2X2mt3hcQTUSs+uoCWoNjQQ1uXDRBSk X-Received: by 10.68.131.202 with SMTP id oo10mr1354124pbb.35.1389956674241; Fri, 17 Jan 2014 03:04:34 -0800 (PST) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id z10sm29433357pas.6.2014.01.17.03.04.31 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 17 Jan 2014 03:04:33 -0800 (PST) From: Sachin Kamat To: linux-fbdev@vger.kernel.org Cc: tomi.valkeinen@ti.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH v2] video: exynos: Fix S6E8AX0 LCD driver build error Date: Fri, 17 Jan 2014 16:30:17 +0530 Message-Id: <1389956417-1299-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver. Else we get the following errors due to missing symbols: drivers/built-in.o: In function `s6e8ax0_probe': :(.text+0x51aec): undefined reference to `lcd_device_register' :(.text+0x51c44): undefined reference to `lcd_device_unregister' Signed-off-by: Sachin Kamat --- drivers/video/exynos/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig index 976594d578a9..eb6f2b059821 100644 --- a/drivers/video/exynos/Kconfig +++ b/drivers/video/exynos/Kconfig @@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI config EXYNOS_LCD_S6E8AX0 bool "S6E8AX0 MIPI AMOLED LCD Driver" - depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE) + depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE + depends on (LCD_CLASS_DEVICE = y) default n help If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its