From patchwork Wed Feb 12 09:49:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 3635871 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 23CFA9F369 for ; Wed, 12 Feb 2014 09:55:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5D15F20165 for ; Wed, 12 Feb 2014 09:55:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F98F201CD for ; Wed, 12 Feb 2014 09:55:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbaBLJzE (ORCPT ); Wed, 12 Feb 2014 04:55:04 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:35306 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752262AbaBLJy4 (ORCPT ); Wed, 12 Feb 2014 04:54:56 -0500 Received: by mail-pa0-f50.google.com with SMTP id kp14so9044282pab.9 for ; Wed, 12 Feb 2014 01:54:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=49nE/mS+5SD7/EfxhP7pjMO3E6KZW1a8kScC8YyqZx4=; b=hAnVXWuzdhhdRfAOnZFl1crdgWM4eDoAqJk9PlBj4BzOaxfA0QmdmlPau4ucsNPrly v2hV/ACLY2+9+M4/GUmAp1lk5tmkizZ/xOw9PuPExX1fhcWe0uXCb5trJqnRaSttEpCC nJvMEbYcVrEpzjPZMKP7gBUPZyAvcklE7rDfxpybQNJ90rBjtj7px2cijbjFw/KeiV7k RsyWi/FV5xfTF90e3mm1ayNy4nBwEBynqXlrA6NDxxivT+zx9c5+pF+lW47mpA/nfMzV YHn8BX7WI1EdzQl5UNCFXDHW3jzQrbG6OzWNBXz27sSI5FI5UiyXd2u1D6N3yveyFjhL sOlQ== X-Gm-Message-State: ALoCoQmg1VyrN994fg6mXgzIkvT1ysq82nw2S+Y4lZiAtCVMhhiZWuDbxQbXCgGEmPAhuyaynk/Z X-Received: by 10.66.197.197 with SMTP id iw5mr13382051pac.25.1392198896264; Wed, 12 Feb 2014 01:54:56 -0800 (PST) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id nz11sm26514376pab.6.2014.02.12.01.54.53 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 12 Feb 2014 01:54:55 -0800 (PST) From: Sachin Kamat To: linux-fbdev@vger.kernel.org Cc: tomi.valkeinen@ti.com, sachin.kamat@linaro.org Subject: [PATCH 1/1] video: exynos: Fix S6E8AX0 LCD driver build error Date: Wed, 12 Feb 2014 15:19:43 +0530 Message-Id: <1392198583-1828-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Enable S6E8AX0 LCD driver only if LCD_CLASS_DEVICE is a built-in driver. Else we get the following errors due to missing symbols: drivers/built-in.o: In function `s6e8ax0_probe': :(.text+0x51aec): undefined reference to `lcd_device_register' :(.text+0x51c44): undefined reference to `lcd_device_unregister' Signed-off-by: Sachin Kamat --- drivers/video/exynos/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/exynos/Kconfig b/drivers/video/exynos/Kconfig index 976594d578a9..eb6f2b059821 100644 --- a/drivers/video/exynos/Kconfig +++ b/drivers/video/exynos/Kconfig @@ -22,7 +22,8 @@ config EXYNOS_MIPI_DSI config EXYNOS_LCD_S6E8AX0 bool "S6E8AX0 MIPI AMOLED LCD Driver" - depends on (EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE && LCD_CLASS_DEVICE) + depends on EXYNOS_MIPI_DSI && BACKLIGHT_CLASS_DEVICE + depends on (LCD_CLASS_DEVICE = y) default n help If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its