| Message ID | 1397266245-3144-1-git-send-email-realmz6@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12/04/14 04:30, Steven Miao wrote: > From: Steven Miao <realmz6@gmail.com> > > should include linux/gpio.h > > Signed-off-by: Steven Miao <realmz6@gmail.com> > --- > drivers/video/bf54x-lq043fb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c > index 42b8f9d..d2b54f1 100644 > --- a/drivers/video/bf54x-lq043fb.c > +++ b/drivers/video/bf54x-lq043fb.c > @@ -49,6 +49,7 @@ > #include <linux/spinlock.h> > #include <linux/dma-mapping.h> > #include <linux/platform_device.h> > +#include <linux/gpio.h> The driver includes <asm/gpio.h>. I think that should be removed, and <linux/gpio.h> should be used. Can you also remove the asm/gpio.h in your patch, and see if it compiles fine? Tomi
Hi Tomi, On Mon, Apr 14, 2014 at 8:44 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > On 12/04/14 04:30, Steven Miao wrote: >> From: Steven Miao <realmz6@gmail.com> >> >> should include linux/gpio.h >> >> Signed-off-by: Steven Miao <realmz6@gmail.com> >> --- >> drivers/video/bf54x-lq043fb.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c >> index 42b8f9d..d2b54f1 100644 >> --- a/drivers/video/bf54x-lq043fb.c >> +++ b/drivers/video/bf54x-lq043fb.c >> @@ -49,6 +49,7 @@ >> #include <linux/spinlock.h> >> #include <linux/dma-mapping.h> >> #include <linux/platform_device.h> >> +#include <linux/gpio.h> > > The driver includes <asm/gpio.h>. I think that should be removed, and > <linux/gpio.h> should be used. Yes, it should be removed. > > Can you also remove the asm/gpio.h in your patch, and see if it compiles > fine? I have tested it, it's fine. I'll resend the patch. > > Tomi > > -steven -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c index 42b8f9d..d2b54f1 100644 --- a/drivers/video/bf54x-lq043fb.c +++ b/drivers/video/bf54x-lq043fb.c @@ -49,6 +49,7 @@ #include <linux/spinlock.h> #include <linux/dma-mapping.h> #include <linux/platform_device.h> +#include <linux/gpio.h> #include <asm/blackfin.h> #include <asm/irq.h>