From patchwork Sat Jul 5 12:12:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4487471 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 54B639F26C for ; Sat, 5 Jul 2014 12:11:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 90CAF202EC for ; Sat, 5 Jul 2014 12:11:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8F23202E9 for ; Sat, 5 Jul 2014 12:11:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754495AbaGEMKu (ORCPT ); Sat, 5 Jul 2014 08:10:50 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:45001 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754247AbaGEMKt (ORCPT ); Sat, 5 Jul 2014 08:10:49 -0400 Received: by mail-wi0-f179.google.com with SMTP id cc10so4743071wib.0 for ; Sat, 05 Jul 2014 05:10:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Gsi/3uz6pZrLLoHJ8IUXwjr8KmY5gbHDbmitJqQehfw=; b=AZrmS7EL0zBGlvrh8r0krhDeWYIQbSvBLlaDdSu5/JcJPzFPu1xGQHBwN5K795+03e D7vfavaabub9yVw4sprZe2J62u0tiFnAmBJs23E/MP4sC0KrNak8rI5n+eR1M3+azmdG vkVxsXR8I1vmskCzszcnuiRTE96kcsfORBtder6804f+Oxo8JkpDyk0aydLuunJh1Cls Jz3DmR3Aa4qoP0J3Rb2V8/5RCFm8gfrgm1jNeJEbJGKfipTZPBSAKXWdrbUX9B50zlRw DqGbT5J+HCwc9zquEFSZQ8yMgkeFtrHnBGgUYkXS5Dfl130Ip35eUkt7uLn7mU4aym9Y lVZQ== X-Gm-Message-State: ALoCoQnJp/sYrZGsELid+/Ovwupe7OLjZful824E5Y0Ph4SIlfWsgdJjfafmd40UNvuoFPySGxaJ X-Received: by 10.194.110.161 with SMTP id ib1mr617422wjb.129.1404562248464; Sat, 05 Jul 2014 05:10:48 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id hq20sm38899868wib.0.2014.07.05.05.10.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jul 2014 05:10:47 -0700 (PDT) From: Rickard Strandqvist To: Jingoo Han , Bryan Wu Cc: Rickard Strandqvist , Rickard Strandqvist , Lee Jones , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: backlight: jornada720_lcd.c: Cleaning up variable that is never used Date: Sat, 5 Jul 2014 14:12:05 +0200 Message-Id: <1404562325-18471-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Rickard Strandqvist Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/backlight/jornada720_lcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c index da3876c..b304319 100644 --- a/drivers/video/backlight/jornada720_lcd.c +++ b/drivers/video/backlight/jornada720_lcd.c @@ -56,12 +56,10 @@ static int jornada_lcd_get_contrast(struct lcd_device *ld) static int jornada_lcd_set_contrast(struct lcd_device *ld, int value) { - int ret; - jornada_ssp_start(); /* start by sending our set contrast cmd to mcu */ - ret = jornada_ssp_byte(SETCONTRAST); + jornada_ssp_byte(SETCONTRAST); /* push the new value */ if (jornada_ssp_byte(value) != TXDUMMY) {