From patchwork Sat Jul 5 12:14:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4487501 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B55839F26C for ; Sat, 5 Jul 2014 12:13:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CE49D20357 for ; Sat, 5 Jul 2014 12:13:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF181202E9 for ; Sat, 5 Jul 2014 12:13:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755430AbaGEMNK (ORCPT ); Sat, 5 Jul 2014 08:13:10 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:36884 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755416AbaGEMNJ (ORCPT ); Sat, 5 Jul 2014 08:13:09 -0400 Received: by mail-wi0-f174.google.com with SMTP id bs8so13991893wib.13 for ; Sat, 05 Jul 2014 05:13:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/oGLhitr4Z8gCSiGPz5F6RWQLsWMeeNLBuTehzhknXU=; b=D1QKOV/0pogRtQ/teXETGDR+nKFtX4u+3fCb6PJrIHDZJqeybKO23TGCJRWSxsjwo2 mx+SJBgeCkUI1sjoP/310qaJHc3seAtBe0S4uqovViL6SxLhBf7h+TnqMmLAGpkH/5mN Sabd9P/oVZdzwu1/Fa14Q9CBPRI0qHAouJeqs5Bo8Zk8K5QFm9zirHoXyp82DiVIJdKt xzz7jLcd6B9/KXz0Onx3j4+kujjd7JaYnhlWx3ztJwPKMFHRZnQJXDLlgWg4O8hnHvuH 0ifdoljaDOMNffnlF2/4Z4mk1NM1F34zP78MOYNKZ3hU/gZsESaTZ/6xWxxGx/pkl9xi Fu3w== X-Gm-Message-State: ALoCoQkzg+LYJQcu7EmFZ9c0gfIzcIpjllh+fBjr7IOBnIM1yD4BPaXh25e34X5z+bp7Il4QTIIx X-Received: by 10.180.21.200 with SMTP id x8mr62892874wie.70.1404562387820; Sat, 05 Jul 2014 05:13:07 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id ey16sm90480750wid.14.2014.07.05.05.13.06 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jul 2014 05:13:06 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Rickard Strandqvist , Geert Uytterhoeven , Jingoo Han , Daniel Vetter , Joe Perches , Michael Schmitz , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: atafb.c: Cleaning up variable that is never used Date: Sat, 5 Jul 2014 14:14:24 +0200 Message-Id: <1404562464-18788-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Rickard Strandqvist Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist Acked-by: Geert Uytterhoeven --- drivers/video/fbdev/atafb.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c index 4953b65..1bedbf35 100644 --- a/drivers/video/fbdev/atafb.c +++ b/drivers/video/fbdev/atafb.c @@ -2546,7 +2546,6 @@ static void atafb_copyarea(struct fb_info *info, const struct fb_copyarea *area) struct atafb_par *par = (struct atafb_par *)info->par; int x2, y2; u32 dx, dy, sx, sy, width, height; - int rev_copy = 0; #ifdef ATAFB_FALCON if (info->var.bits_per_pixel == 16) { @@ -2580,7 +2579,6 @@ static void atafb_copyarea(struct fb_info *info, const struct fb_copyarea *area) if (dy > sy || (dy == sy && dx > sx)) { dy += height; sy += height; - rev_copy = 1; } if (info->var.bits_per_pixel == 1) @@ -2599,8 +2597,6 @@ static void atafb_imageblit(struct fb_info *info, const struct fb_image *image) { struct atafb_par *par = (struct atafb_par *)info->par; int x2, y2; - unsigned long *dst; - int dst_idx; const char *src; u32 dx, dy, width, height, pitch; @@ -2627,10 +2623,6 @@ static void atafb_imageblit(struct fb_info *info, const struct fb_image *image) if (image->depth == 1) { // used for font data - dst = (unsigned long *) - ((unsigned long)info->screen_base & ~(BYTES_PER_LONG - 1)); - dst_idx = ((unsigned long)info->screen_base & (BYTES_PER_LONG - 1)) * 8; - dst_idx += dy * par->next_line * 8 + dx; src = image->data; pitch = (image->width + 7) / 8; while (height--) {