From patchwork Sat Jul 5 12:30:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4487881 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6F1DCBEEAA for ; Sat, 5 Jul 2014 12:29:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8426F20357 for ; Sat, 5 Jul 2014 12:29:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F616202A1 for ; Sat, 5 Jul 2014 12:29:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754003AbaGEM3l (ORCPT ); Sat, 5 Jul 2014 08:29:41 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:44169 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751169AbaGEM3k (ORCPT ); Sat, 5 Jul 2014 08:29:40 -0400 Received: by mail-wg0-f44.google.com with SMTP id k14so2502817wgh.15 for ; Sat, 05 Jul 2014 05:29:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VIVB4+xO9qDJf6NlYtw8YfqLp6BaJkQpEEl01e9YVkk=; b=R8iIxnw3sCbBqMu2g71tX7V8LYnFOooBykYdxLC2FXJ85pmYZrYLZwF0r2lBXcSx/d 0i0U6RcKB9UcOIjkALs5W7SfgzmVb/XZqpb+QSRrO0f9LkHIyCNwfnXzQPbRVM5QuTvX psannDI964waA8VhNXTwUj6Fv+HmU2ZTRe4WJ6FkcLef6Xd1ZlRQjUxmDM+9TvJ7jkJe +E4qkzN9qtN99ZEjZQwT7zVFJnt6wMULhEbyBGg2okVD838e000wmRh/Z6Y1OzDtPbcd q822cJhSmJPgCGHR9BdFVYZw2Xrmj6ac7106ssgxVUodR4BI1vBjGKO4CeO3sgFUlLQw ruPg== X-Gm-Message-State: ALoCoQmq/F2FtJ3ldB1th53p9ubmS/zqc2gFqz/AcIFEEGmq9d0PZMnkPhx6XHVWNrgFJTvwbWDh X-Received: by 10.194.90.201 with SMTP id by9mr19249116wjb.94.1404563379359; Sat, 05 Jul 2014 05:29:39 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id au7sm18700695wjc.41.2014.07.05.05.29.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jul 2014 05:29:38 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Rickard Strandqvist , Jingoo Han , Daniel Vetter , Joe Perches , Laurent Pinchart , Arnd Bergmann , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: mbx: mbxfb.c: Cleaning up variable that is never used Date: Sat, 5 Jul 2014 14:30:55 +0200 Message-Id: <1404563456-20273-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Rickard Strandqvist Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/mbx/mbxfb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/mbx/mbxfb.c b/drivers/video/fbdev/mbx/mbxfb.c index 2bd52ed..320f263 100644 --- a/drivers/video/fbdev/mbx/mbxfb.c +++ b/drivers/video/fbdev/mbx/mbxfb.c @@ -689,7 +689,6 @@ static struct fb_ops mbxfb_ops = { */ static void setup_memc(struct fb_info *fbi) { - unsigned long tmp; int i; /* FIXME: use platform specific parameters */ @@ -714,7 +713,7 @@ static void setup_memc(struct fb_info *fbi) write_reg_dly(LMPWR_MC_PWR_ACT, LMPWR); /* perform dummy reads */ for ( i = 0; i < 16; i++ ) { - tmp = readl(fbi->screen_base); + readl(fbi->screen_base); } }