From patchwork Sat Jul 5 12:42:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4488111 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 55D6EBEEAA for ; Sat, 5 Jul 2014 12:41:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 82AEB201F2 for ; Sat, 5 Jul 2014 12:41:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4AA1201EF for ; Sat, 5 Jul 2014 12:41:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754975AbaGEMlO (ORCPT ); Sat, 5 Jul 2014 08:41:14 -0400 Received: from mail-we0-f179.google.com ([74.125.82.179]:55144 "EHLO mail-we0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752951AbaGEMlN (ORCPT ); Sat, 5 Jul 2014 08:41:13 -0400 Received: by mail-we0-f179.google.com with SMTP id w62so2540273wes.24 for ; Sat, 05 Jul 2014 05:41:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=DyrACziIEYDVC5p/IoNel+hQLnxxcFX6/P9DX6OiPdA=; b=WBq3fDIXcjTyvaO0YMpDabZR89WQl41VG7X8JONLnhpn3M11Ez29We8ah29ljvN/rl jOAuMD+KEXpMxI1e+ba2x8j2WX/PUsY7R6BPOUVZzwhe9mFIulpLcTMbevDmktXt9nsD vTYnOgn5H5Gre9ksWLXuyyLjrt0nj/wBiCxJpmAHSKcbbHBFMvqhxxdPhrwR1ejssMoC suaGNHkV5p5rbXqWGbizE0j+KQKPy9+UDumW+t5mvLeGEyCGHjLTu/8g9iDFq5Fx4/4m GVMQhKTaFwDCgNui4ghtk0+qQUuF1GXUv0TJthzv+F6vB3AtHeBFBLgPlJiR2lCHH47b TC1Q== X-Gm-Message-State: ALoCoQkZ2i2wW69Ow8Tk5y4s735UlMHRY8i6I7iU2rGC+a7/kSyoOsJNOulSxLdOcz7XG6YARnt+ X-Received: by 10.180.208.35 with SMTP id mb3mr57734500wic.48.1404564072454; Sat, 05 Jul 2014 05:41:12 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id fs17sm37300017wjc.6.2014.07.05.05.41.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jul 2014 05:41:11 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Rickard Strandqvist , Jingoo Han , Daniel Vetter , Archit Taneja , Laurent Pinchart , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: omap2: dss: rfbi.c: Cleaning up variable that is never used Date: Sat, 5 Jul 2014 14:42:29 +0200 Message-Id: <1404564149-21193-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Rickard Strandqvist Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/omap2/dss/rfbi.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/video/fbdev/omap2/dss/rfbi.c b/drivers/video/fbdev/omap2/dss/rfbi.c index c8a81a2..6f03bbb 100644 --- a/drivers/video/fbdev/omap2/dss/rfbi.c +++ b/drivers/video/fbdev/omap2/dss/rfbi.c @@ -574,7 +574,6 @@ static int rfbi_setup_te(enum omap_rfbi_te_mode mode, { int hs, vs; int min; - u32 l; hs = ps_to_rfbi_ticks(hs_pulse_time, 1); vs = ps_to_rfbi_ticks(vs_pulse_time, 1); @@ -595,15 +594,7 @@ static int rfbi_setup_te(enum omap_rfbi_te_mode mode, rfbi_write_reg(RFBI_HSYNC_WIDTH, hs); rfbi_write_reg(RFBI_VSYNC_WIDTH, vs); - l = rfbi_read_reg(RFBI_CONFIG(0)); - if (hs_pol_inv) - l &= ~(1 << 21); - else - l |= 1 << 21; - if (vs_pol_inv) - l &= ~(1 << 20); - else - l |= 1 << 20; + rfbi_read_reg(RFBI_CONFIG(0)); return 0; }