From patchwork Sat Jul 5 12:50:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4488261 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6AF7DBEEAA for ; Sat, 5 Jul 2014 12:49:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 90455202BE for ; Sat, 5 Jul 2014 12:49:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE04B20265 for ; Sat, 5 Jul 2014 12:49:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753939AbaGEMtJ (ORCPT ); Sat, 5 Jul 2014 08:49:09 -0400 Received: from mail-we0-f172.google.com ([74.125.82.172]:54495 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbaGEMtI (ORCPT ); Sat, 5 Jul 2014 08:49:08 -0400 Received: by mail-we0-f172.google.com with SMTP id u57so2490486wes.3 for ; Sat, 05 Jul 2014 05:49:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ACM9w3KY5LjdtsQGx8+BQTU8AiojPSp/rqtrlj5suP8=; b=XMqdM8+q9Tv5z5efrpi9zAG0SuBQYcWmHyirU48mwQWYnKKOSx/eLL4ZEMzpX5gP/l LVlWY4zo+eFNYNtrw++0UYifogfJHSEn7Me7OYCIidavbincwdAlKa6g6eeV/AMcKNir CVDkrG1gW79Wqlga/Schb5AoCV/xkZR2tNJsKsaI2uroa3Z06Bt+9qjxxnm7qpfM7LXv fgPxHO735t1hHiJEmjd25/BJaZWgAcAMq1C3GrUhagQOblgJv5w3Z9DrCdZ+6/2wpMCP 0qps3YTwSTl+8BexYOzww3sUL9dXOTYGSFBDZbiFO3axBwbcN60Jf4ln1+gO2jbOdAwA WwoA== X-Gm-Message-State: ALoCoQlbDqkpCR4j6dyGStgHTC+sQjU/zGrPSQU2oePxnMIfUnDtcdO7DbMzWAViJ2M0xNoV/jr1 X-Received: by 10.180.126.9 with SMTP id mu9mr23076235wib.69.1404564547144; Sat, 05 Jul 2014 05:49:07 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id fb15sm90786941wid.23.2014.07.05.05.49.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Jul 2014 05:49:06 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Rickard Strandqvist , Jingoo Han , Laurent Pinchart , Rob Clark , Daniel Vetter , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: tdfxfb.c: Cleaning up variable that is never used Date: Sat, 5 Jul 2014 14:50:23 +0200 Message-Id: <1404564624-21897-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Rickard Strandqvist Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/tdfxfb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index f761fe3..4efb2de 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -224,9 +224,7 @@ static inline u8 crt_inb(struct tdfx_par *par, u32 idx) static inline void att_outb(struct tdfx_par *par, u32 idx, u8 val) { - unsigned char tmp; - - tmp = vga_inb(par, IS1_R); + vga_inb(par, IS1_R); vga_outb(par, ATT_IW, idx); vga_outb(par, ATT_IW, val); }