From patchwork Sun Jul 6 17:36:30 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4490191 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9A255BEEAA for ; Sun, 6 Jul 2014 17:35:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CAC9320265 for ; Sun, 6 Jul 2014 17:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EAFF62024D for ; Sun, 6 Jul 2014 17:35:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbaGFRfQ (ORCPT ); Sun, 6 Jul 2014 13:35:16 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:37603 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbaGFRfP (ORCPT ); Sun, 6 Jul 2014 13:35:15 -0400 Received: by mail-wi0-f180.google.com with SMTP id hi2so5659176wib.1 for ; Sun, 06 Jul 2014 10:35:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ieMQtx0JppbJQSe2VTNGOmXe+XgX8bllJCYf3g2aVrM=; b=Ab36dMXvohjKC/tekGdcfBWZwOKV+EcAQqTqxCmcEPb/6ie/KYM7js7iQIQAjO0cRv PjpiKkzVE4grI/GgZcVgwfrrPHk0UUrwPyNZo2mhAQ9knec2cMwgC+H38TKxaeyfZWhO CW0XhM+SCmzXicx+FPARt1RMSjLtoZGxnF5klWkk6lArKnsd4hxnY4mQ0Hc9dcHvqtUm V0PJD8H9ceissMQHj4K5Pl80aMF3Qq5qfad6swJysrIvOh4GauPzluoQRyxnUqQCfs2D Yn4k35c10k8CLCgMDfAlxxLFc8BdhRpz3fENQvM4CuJdbuNE656q71LtVFOciWf+gmO9 xVrA== X-Gm-Message-State: ALoCoQm/SYBaWBKhMltdJJT1B13b1XYWng/417kYfTjwSZ4gbYnCU7+K+fX1vN+ckcJfnAFFug8N X-Received: by 10.180.91.194 with SMTP id cg2mr32064885wib.12.1404668114182; Sun, 06 Jul 2014 10:35:14 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id fb8sm105197040wib.15.2014.07.06.10.35.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jul 2014 10:35:13 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Jingoo Han , Daniel Vetter , Joe Perches , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: sis: sis_main.c: Cleaning up wrong type in format string Date: Sun, 6 Jul 2014 19:36:30 +0200 Message-Id: <1404668190-15199-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Wrong type in printf format string, requires 'unsigned int' but the argument type is 'int' This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/sis/sis_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c index 22ad028..ab7e5e4 100644 --- a/drivers/video/fbdev/sis/sis_main.c +++ b/drivers/video/fbdev/sis/sis_main.c @@ -237,7 +237,7 @@ static void sisfb_get_vga_mode_from_kernel(void) if(mydepth == 24) mydepth = 32; - sprintf(mymode, "%ux%ux%u", screen_info.lfb_width, + sprintf(mymode, "%ux%ux%d", screen_info.lfb_width, screen_info.lfb_height, mydepth);