From patchwork Sun Jul 6 18:21:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4490471 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id EA9FB9F36A for ; Sun, 6 Jul 2014 18:20:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 30CC3202A1 for ; Sun, 6 Jul 2014 18:20:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56B8A2021A for ; Sun, 6 Jul 2014 18:20:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751924AbaGFSUc (ORCPT ); Sun, 6 Jul 2014 14:20:32 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:37762 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbaGFSUb (ORCPT ); Sun, 6 Jul 2014 14:20:31 -0400 Received: by mail-wi0-f181.google.com with SMTP id n3so5793251wiv.14 for ; Sun, 06 Jul 2014 11:20:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=abSMR2HiW2EM4KFpa4rwdg4K0FTLIDw1+iiev7lQWqI=; b=liXOoNS8JnIAabJNDPJIKlmFG5TytesuqWMMIpgnhCA5mkuZGYYWAz7wsmEBsfwRQn ecD3VPgcoZ57t+IIEWt0UAq2g3jAO+iv4Mvq84pv3VHHMLGATmb20SQpQJei6fNUxgFM 2LV0f2jk8GsaTl4GUaKFtScN0pQraJs3gOvXdJsw1oLbldkVviZSgzdWlzW5omql/wWm rF6XtBIgZHP3QVccHnh+fYDWDH6vx6C+yXqrgWVeoyU8afzve7JKv12Oz/eETyGzQa+k rhHn1MU4I7O5zLKl0yH9IiT7vsjE3f6rk3LBvYrNAK7MxS+1ipVeqTFVseZVQj90Lhg9 0s5A== X-Gm-Message-State: ALoCoQm0NVpa8fR/2pUvg3t6EbFAVMGwGY0I0eVHiN4+dMfw534f3c8Mv/xCOjgB+pbnQzWpshao X-Received: by 10.180.94.104 with SMTP id db8mr69199192wib.23.1404670830469; Sun, 06 Jul 2014 11:20:30 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id nc19sm51195199wic.4.2014.07.06.11.20.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jul 2014 11:20:29 -0700 (PDT) From: Rickard Strandqvist To: Jingoo Han , Bryan Wu Cc: Rickard Strandqvist , Lee Jones , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: backlight: jornada720_lcd.c: Cleaning up variable that is never used Date: Sun, 6 Jul 2014 20:21:46 +0200 Message-Id: <1404670906-17335-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/backlight/jornada720_lcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/backlight/jornada720_lcd.c b/drivers/video/backlight/jornada720_lcd.c index da3876c..b304319 100644 --- a/drivers/video/backlight/jornada720_lcd.c +++ b/drivers/video/backlight/jornada720_lcd.c @@ -56,12 +56,10 @@ static int jornada_lcd_get_contrast(struct lcd_device *ld) static int jornada_lcd_set_contrast(struct lcd_device *ld, int value) { - int ret; - jornada_ssp_start(); /* start by sending our set contrast cmd to mcu */ - ret = jornada_ssp_byte(SETCONTRAST); + jornada_ssp_byte(SETCONTRAST); /* push the new value */ if (jornada_ssp_byte(value) != TXDUMMY) {