From patchwork Sun Jul 6 18:27:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4490601 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 854449F36A for ; Sun, 6 Jul 2014 18:26:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id ADC75201FA for ; Sun, 6 Jul 2014 18:26:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC240201DD for ; Sun, 6 Jul 2014 18:26:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751904AbaGFS0p (ORCPT ); Sun, 6 Jul 2014 14:26:45 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:35943 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbaGFS0o (ORCPT ); Sun, 6 Jul 2014 14:26:44 -0400 Received: by mail-wi0-f173.google.com with SMTP id cc10so14794634wib.12 for ; Sun, 06 Jul 2014 11:26:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=mYBUJy/4oqp9RplQyC1IEtrlEmcW+HGEfrqKAQAyNEk=; b=HVEwPVcAAJN291xsO4JcTPqdVT1vJ+ZCqUpiVLt0C6AQkf1Bn8lcYfRyDSUXuj1GWi gd02XEijwq+Pcls4oyGKBruWEPsc/+W3gAgvSIGsL7/9Imzqhkir8y5joHTFLKzRBgHb +w2dmkIZBUPF/wJbzHKbAPXAwNZ/QrVrxg82ru8o8OkCs6+QPO3IV5MOqHm20jBRgo5A 6BEcKQqgjo6K9YeOXlqXFK+0Nfh59nyAWyYDWAmT+zS0ojkkC3JFoiytOAdzT20jzlq2 zX8oh9GFy41wrtGn+3spiSnY5WB6P4ugIslimgk0Onlf+AN9/YC315pIr8AwZKvn3dX2 x/vw== X-Gm-Message-State: ALoCoQkHU8KEccenQ6tpDzbBz861y7UpIGvAOIYQu0/l8cGUntozapIGziHMXYS/I5LMagA1CH7R X-Received: by 10.180.102.100 with SMTP id fn4mr13386930wib.22.1404671203442; Sun, 06 Jul 2014 11:26:43 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id jy8sm84045214wjc.7.2014.07.06.11.26.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jul 2014 11:26:42 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Jingoo Han , Daniel Vetter , Laurent Pinchart , Hanjun Guo , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: au1200fb.c: Cleaning up variable that is never used Date: Sun, 6 Jul 2014 20:27:59 +0200 Message-Id: <1404671279-17856-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/au1200fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c index 4cfba78..2249d3d 100644 --- a/drivers/video/fbdev/au1200fb.c +++ b/drivers/video/fbdev/au1200fb.c @@ -710,7 +710,7 @@ static int fbinfo2index (struct fb_info *fb_info) static int au1200_setlocation (struct au1200fb_device *fbdev, int plane, int xpos, int ypos) { - uint32 winctrl0, winctrl1, winenable, fb_offset = 0; + uint32 winctrl0, winctrl1, winenable; int xsz, ysz; /* FIX!!! NOT CHECKING FOR COMPLETE OFFSCREEN YET */ @@ -738,7 +738,6 @@ static int au1200_setlocation (struct au1200fb_device *fbdev, int plane, if (xpos < 0) { /* Off-screen to the left */ xsz = win->w[plane].xres + xpos; - fb_offset += (((0 - xpos) * winbpp(lcd->window[plane].winctrl1))/8); xpos = 0; /*printk("off screen left\n");*/ }