From patchwork Sun Jul 6 18:42:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4491101 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 72240BEEAA for ; Sun, 6 Jul 2014 18:41:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9C00F20253 for ; Sun, 6 Jul 2014 18:41:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D48D72024C for ; Sun, 6 Jul 2014 18:41:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751933AbaGFSlN (ORCPT ); Sun, 6 Jul 2014 14:41:13 -0400 Received: from mail-we0-f175.google.com ([74.125.82.175]:60630 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751812AbaGFSlM (ORCPT ); Sun, 6 Jul 2014 14:41:12 -0400 Received: by mail-we0-f175.google.com with SMTP id k48so3422145wev.20 for ; Sun, 06 Jul 2014 11:41:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8RZ1GB2C17M3QrpOVuJTi3iKHlL/0wYUzaY30h51xD8=; b=N0jVdyTpHxXkrHSX9PdTPEPRcsZmgMMYip3ESzn5Nl1qrHwg6Fs2T4wfwDmcv6F9fv 6Usloq1ME7zZRqBYzpEVPXl8ZS1gBp/WCqMGNnVgJgeY+9YUWsTU+wrwUfv3fjWo4fHJ gM/jWmUlb4gRKHWuH5i18YdJRJAw6yI2hJH6WRfRxWC67VzJ2li4ZkbanbJOY/FZ2S4g Sa38zH87LwJIeF6ZZWw/wDvB1o9X2yIlM65+3pWIfxHc/UP5KA2Jcrs65/rV1rBQAeBL 1n/ejC7XFu4Rg7z1173APieKwO9SIDvOdJt2ResQtC89Q9G2gn2dSxtpShzoAr+BkJ2s 6riQ== X-Gm-Message-State: ALoCoQnbkYuYLHOD7yq/bsNcp6eNAXrlqRU2Vt7IEMkj8gRoFCmzLrNYkJK9rKPl3Mb/jebzEnqV X-Received: by 10.180.221.196 with SMTP id qg4mr31893143wic.66.1404672071652; Sun, 06 Jul 2014 11:41:11 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id go4sm12642761wjc.39.2014.07.06.11.41.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jul 2014 11:41:11 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Jingoo Han , Laurent Pinchart , Rob Clark , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: msm: mddi.c: Cleaning up variable that is never used Date: Sun, 6 Jul 2014 20:42:28 +0200 Message-Id: <1404672148-19061-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/msm/mddi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/msm/mddi.c b/drivers/video/fbdev/msm/mddi.c index e0f8011..d65ff75a 100644 --- a/drivers/video/fbdev/msm/mddi.c +++ b/drivers/video/fbdev/msm/mddi.c @@ -257,12 +257,12 @@ static irqreturn_t mddi_isr(int irq, void *data) struct msm_mddi_client_data *cdata = data; struct mddi_info *mddi = container_of(cdata, struct mddi_info, client_data); - uint32_t active, status; + uint32_t active; spin_lock(&mddi->int_lock); active = mddi_readl(INT); - status = mddi_readl(STAT); + mddi_readl(STAT); mddi_writel(active, INT); @@ -548,7 +548,6 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg) struct mddi_llentry *ll; struct mddi_register_access *ra; struct reg_read_info ri; - unsigned s; int retry_count = 2; unsigned long irq_flags; @@ -572,7 +571,7 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg) ll->next = 0; ll->reserved = 0; - s = mddi_readl(STAT); + mddi_readl(STAT); ri.reg = reg; ri.status = -1;