From patchwork Sun Jul 6 18:49:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4491311 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E11AB9F26C for ; Sun, 6 Jul 2014 18:48:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 191C520253 for ; Sun, 6 Jul 2014 18:48:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 484B02024C for ; Sun, 6 Jul 2014 18:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752178AbaGFSs2 (ORCPT ); Sun, 6 Jul 2014 14:48:28 -0400 Received: from mail-we0-f171.google.com ([74.125.82.171]:63509 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbaGFSs1 (ORCPT ); Sun, 6 Jul 2014 14:48:27 -0400 Received: by mail-we0-f171.google.com with SMTP id q58so3482854wes.16 for ; Sun, 06 Jul 2014 11:48:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=NpF4BJmimHZe8n6n0ileAvkojM2Iv3WFnKXs2NrO050=; b=NMzFO9VRU+yj+34kQLr+U2PRjSJeF4U9EKuovFF0YzEnwN8Kcft51xK6HuHsd6VZqI KRmXYZzG4cVjrRoZ+4Hzhthn0aEpk7db2mIIf5n2h8hTvzsKZzqI6wGWbDgi0Hw+CHIV JntYbv51l08QnxsEjqotGBuxKlIBr7IbWOe4meyaEjTHMvb9vZ5y+VzMhvUIXmzjW0sh RfMNf9LhiegeDa4oAe1ynpiSVrqiGxyiznAEFTY/C8N3KaCASnktOkfMV77ylSAMy7/6 vZM/sWSUCT9EgcgXaNVrecLkH4usW4rMuaS7tozBIj3SP0Ga2xoJSUKbIiR/Hyasttf4 TYGQ== X-Gm-Message-State: ALoCoQmztEll3ZY2ahyZLWd6O0Gb6zbHkQVc+TCLlyXWSMVZEsC1FFVxjHcrse44xMrZPQBjgBbx X-Received: by 10.180.73.106 with SMTP id k10mr69139816wiv.11.1404672506158; Sun, 06 Jul 2014 11:48:26 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id go4sm12678637wjc.39.2014.07.06.11.48.24 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jul 2014 11:48:25 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Grant Likely , Rob Herring , Archit Taneja , Tony Lindgren , Jingoo Han , Sathya Prakash M R , Joe Perches , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH] video: fbdev: omap2: dss: dsi.c: Cleaning up variable that is never used Date: Sun, 6 Jul 2014 20:49:42 +0200 Message-Id: <1404672582-19651-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/omap2/dss/dsi.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/omap2/dss/dsi.c b/drivers/video/fbdev/omap2/dss/dsi.c index 4755a34..32d2ba6 100644 --- a/drivers/video/fbdev/omap2/dss/dsi.c +++ b/drivers/video/fbdev/omap2/dss/dsi.c @@ -1207,13 +1207,12 @@ static inline void dsi_enable_pll_clock(struct platform_device *dsidev, static void _dsi_print_reset_status(struct platform_device *dsidev) { - u32 l; int b0, b1, b2; /* A dummy read using the SCP interface to any DSIPHY register is * required after DSIPHY reset to complete the reset of the DSI complex * I/O. */ - l = dsi_read_reg(dsidev, DSI_DSIPHY_CFG5); + dsi_read_reg(dsidev, DSI_DSIPHY_CFG5); if (dss_has_feature(FEAT_DSI_REVERSE_TXCLKESC)) { b0 = 28; @@ -3902,7 +3901,7 @@ static int dsi_proto_config(struct platform_device *dsidev) static void dsi_proto_timings(struct platform_device *dsidev) { struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev); - unsigned tlpx, tclk_zero, tclk_prepare, tclk_trail; + unsigned tlpx, tclk_zero, tclk_prepare; unsigned tclk_pre, tclk_post; unsigned ths_prepare, ths_prepare_ths_zero, ths_zero; unsigned ths_trail, ths_exit; @@ -3921,7 +3920,7 @@ static void dsi_proto_timings(struct platform_device *dsidev) r = dsi_read_reg(dsidev, DSI_DSIPHY_CFG1); tlpx = FLD_GET(r, 20, 16) * 2; - tclk_trail = FLD_GET(r, 15, 8); + FLD_GET(r, 15, 8); tclk_zero = FLD_GET(r, 7, 0); r = dsi_read_reg(dsidev, DSI_DSIPHY_CFG2); @@ -4669,12 +4668,11 @@ static void print_dsi_dispc_vm(const char *str, unsigned long byteclk = t->hsclk / 4; unsigned long pck; u64 dsi_tput; - int dsi_hact, dsi_htot; + int dsi_hact; dsi_tput = (u64)byteclk * t->ndl * 8; pck = (u32)div64_u64(dsi_tput, t->bitspp); dsi_hact = DIV_ROUND_UP(DIV_ROUND_UP(t->hact * t->bitspp, 8) + 6, t->ndl); - dsi_htot = t->hss + t->hsa + t->hse + t->hbp + dsi_hact + t->hfp; vm.pixelclock = pck; vm.hsw = div64_u64((u64)(t->hsa + t->hse) * pck, byteclk);