From patchwork Sun Jul 6 18:53:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4491361 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4BDE49F36A for ; Sun, 6 Jul 2014 18:51:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 782D82024C for ; Sun, 6 Jul 2014 18:51:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6ABB20220 for ; Sun, 6 Jul 2014 18:51:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090AbaGFSvu (ORCPT ); Sun, 6 Jul 2014 14:51:50 -0400 Received: from mail-we0-f175.google.com ([74.125.82.175]:56092 "EHLO mail-we0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbaGFSvt (ORCPT ); Sun, 6 Jul 2014 14:51:49 -0400 Received: by mail-we0-f175.google.com with SMTP id k48so3428218wev.20 for ; Sun, 06 Jul 2014 11:51:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=8rvqdbKtQ1bJZwjmzo1DDX9z7O8uwKXXLFw6Wf9k55Q=; b=GBajiqRD0HcfCzmsHBqwOQT2IVSB8Cpdr4cv6TZFBf+KKxd7iJiUCjStgGbTY9IDGK du4xEHDYg+g0fdtDwDLK4vcYZs35VrUmxUwGbYX2wqh82MgYNlfaLs4TcGg6LlWJqit7 qumvWHEZ9NHgI018mG5Ot1MVBTj3KSuwxYUiRa3NhvR7YvcpNsDYh83e0W+5f5bx68RP VEjQQuy8Je2/IV7bYjQECJ++pnrL/UkPvFC5ULZRSwS8Re+qGVhFHPGvocFm24mJId06 t+bNi8BVftnAINtIkJdfUog2EKvfdNNXrEtemgcE0AJhi/LZ54Eoc9r9OHB48TUXHseN Tjpw== X-Gm-Message-State: ALoCoQmqOt3p69NW6DuIGLHjQKhN8B+tZLix8Ys+TtmPsx8oW901OBxiINl2jCFxOe/AYeKBr33s X-Received: by 10.194.71.52 with SMTP id r20mr1064658wju.113.1404672708569; Sun, 06 Jul 2014 11:51:48 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id cz4sm105831912wib.23.2014.07.06.11.51.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jul 2014 11:51:47 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Jingoo Han , Daniel Vetter , Archit Taneja , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: omap2: dss: rfbi.c: Cleaning up variable that is never used Date: Sun, 6 Jul 2014 20:53:04 +0200 Message-Id: <1404672784-19903-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/omap2/dss/rfbi.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/video/fbdev/omap2/dss/rfbi.c b/drivers/video/fbdev/omap2/dss/rfbi.c index c8a81a2..6f03bbb 100644 --- a/drivers/video/fbdev/omap2/dss/rfbi.c +++ b/drivers/video/fbdev/omap2/dss/rfbi.c @@ -574,7 +574,6 @@ static int rfbi_setup_te(enum omap_rfbi_te_mode mode, { int hs, vs; int min; - u32 l; hs = ps_to_rfbi_ticks(hs_pulse_time, 1); vs = ps_to_rfbi_ticks(vs_pulse_time, 1); @@ -595,15 +594,7 @@ static int rfbi_setup_te(enum omap_rfbi_te_mode mode, rfbi_write_reg(RFBI_HSYNC_WIDTH, hs); rfbi_write_reg(RFBI_VSYNC_WIDTH, vs); - l = rfbi_read_reg(RFBI_CONFIG(0)); - if (hs_pol_inv) - l &= ~(1 << 21); - else - l |= 1 << 21; - if (vs_pol_inv) - l &= ~(1 << 20); - else - l |= 1 << 20; + rfbi_read_reg(RFBI_CONFIG(0)); return 0; }