From patchwork Sun Jul 6 18:55:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4491401 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 18860BEEAA for ; Sun, 6 Jul 2014 18:53:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 36B4220253 for ; Sun, 6 Jul 2014 18:53:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B2FE2024C for ; Sun, 6 Jul 2014 18:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752178AbaGFSxx (ORCPT ); Sun, 6 Jul 2014 14:53:53 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:56603 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752116AbaGFSxx (ORCPT ); Sun, 6 Jul 2014 14:53:53 -0400 Received: by mail-wi0-f177.google.com with SMTP id r20so5808366wiv.16 for ; Sun, 06 Jul 2014 11:53:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wK4yuaXNqd+6/vfAnEhSpq6EvwG43Ytr+yJS6bcbSAg=; b=deW5qQ5euXLrmysc+uM5y+KjbvcE3Z2C2J0Ih8g4uAG0ObEFeUrL03gTCAafv69KTA KOzaIUNlJXVAaSZeaV2ys7aCfvOht8Q73Lwnpe9/Ycf83r+MHnweoghnbBQUUETxMm4J TeCxheGC5p2QzxQsu36TlMSqIrxGDQtMbb09Rvn/zbKJa6eeuEzwlLn2vmBCbQ4yOmfp YiG5tIPKlpFVV6nAr8dNBGRnlRbsCx+JSIg684F3rdFYwKMn/Bmo0c4mJV7LwGTBnGjq K/HfKUsrZZNGyaxtSKA10GEGbUcWwX0K9/JxE7LGhXmBsQOMQnITgqj8ldYlWpKYAeV5 cozw== X-Gm-Message-State: ALoCoQkA/5qPlTDvmaFN26FoAEkgqh4D5KUaRye+wXhQOA/idq22a63P81Hoi4y8e79K7nVuC3hK X-Received: by 10.180.96.97 with SMTP id dr1mr71564799wib.19.1404672832156; Sun, 06 Jul 2014 11:53:52 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id m3sm105928856wik.7.2014.07.06.11.53.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jul 2014 11:53:51 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Jingoo Han , Laurent Pinchart , Rob Clark , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: pxa168fb.c: Cleaning up variable that is never used Date: Sun, 6 Jul 2014 20:55:08 +0200 Message-Id: <1404672908-20071-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/pxa168fb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c index c95b9e4..fd6c56b 100644 --- a/drivers/video/fbdev/pxa168fb.c +++ b/drivers/video/fbdev/pxa168fb.c @@ -405,9 +405,8 @@ static int pxa168fb_set_par(struct fb_info *info) struct fb_var_screeninfo *var = &info->var; struct fb_videomode mode; u32 x; - struct pxa168fb_mach_info *mi; - mi = dev_get_platdata(fbi->dev); + dev_get_platdata(fbi->dev); /* * Set additional mode info. @@ -787,7 +786,6 @@ static int pxa168fb_remove(struct platform_device *pdev) { struct pxa168fb_info *fbi = platform_get_drvdata(pdev); struct fb_info *info; - int irq; unsigned int data; if (!fbi) @@ -807,7 +805,7 @@ static int pxa168fb_remove(struct platform_device *pdev) if (info->cmap.len) fb_dealloc_cmap(&info->cmap); - irq = platform_get_irq(pdev, 0); + platform_get_irq(pdev, 0); dma_free_writecombine(fbi->dev, PAGE_ALIGN(info->fix.smem_len), info->screen_base, info->fix.smem_start);