From patchwork Sun Jul 6 19:00:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4491501 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2A3339F36A for ; Sun, 6 Jul 2014 18:59:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5CBC920253 for ; Sun, 6 Jul 2014 18:59:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85F6D2024C for ; Sun, 6 Jul 2014 18:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752251AbaGFS7E (ORCPT ); Sun, 6 Jul 2014 14:59:04 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:42929 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752032AbaGFS7D (ORCPT ); Sun, 6 Jul 2014 14:59:03 -0400 Received: by mail-wi0-f182.google.com with SMTP id bs8so5679280wib.15 for ; Sun, 06 Jul 2014 11:59:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZdfjFOpAenMfFGMb3jyF7Wr3N/lePhr70/5R1ayzuik=; b=EbwzTKTmaoVhM4a5VEVp16SWNLOUkyGWVFg56FMxb7Bp9djU5vuQdEm35zNcSQTCrt rI7WyDwaQDuQC7jNTiiHjy7PSQhuvth3kfleHYDPJVjIoquGsiRk5hg4TNbd2yJrHPtN 1nUbnoZr8mc8O4WgJhfd6UR8dZYXNTq56MotauA/DUnMKBm5KHReaOGu3q1OG6/RLJXo 88m1eC6hBnaVmYU1Cjlc6oQIykAqtqUREpomLb79e4vFz6MxBZPeWbl7a5o2esa4I3V6 apKd2L5BjaLz/6pRJqBUYeWbWeDLZS0fzcxBm1PPfLIWOXHyjFX9AwSYXfgxOqDPX94V vmpg== X-Gm-Message-State: ALoCoQnKDSC/b+6Nb6yYrJ7TI+C5Rf73X9CKQmnuxkPUGfqKUYFYfzi1uPaOPPy5c9zTlPKIGkYy X-Received: by 10.180.39.144 with SMTP id p16mr31134428wik.4.1404673142117; Sun, 06 Jul 2014 11:59:02 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id s3sm84178237wje.36.2014.07.06.11.59.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jul 2014 11:59:01 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Jingoo Han , Laurent Pinchart , Rob Clark , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: tdfxfb.c: Cleaning up variable that is never used Date: Sun, 6 Jul 2014 21:00:18 +0200 Message-Id: <1404673218-20500-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/tdfxfb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index f761fe3..4efb2de 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -224,9 +224,7 @@ static inline u8 crt_inb(struct tdfx_par *par, u32 idx) static inline void att_outb(struct tdfx_par *par, u32 idx, u8 val) { - unsigned char tmp; - - tmp = vga_inb(par, IS1_R); + vga_inb(par, IS1_R); vga_outb(par, ATT_IW, idx); vga_outb(par, ATT_IW, val); }