From patchwork Sun Jul 6 19:02:22 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4491551 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CB4A59F36A for ; Sun, 6 Jul 2014 19:01:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 010D7201C7 for ; Sun, 6 Jul 2014 19:01:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CEBD20160 for ; Sun, 6 Jul 2014 19:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752258AbaGFTBI (ORCPT ); Sun, 6 Jul 2014 15:01:08 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:54273 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752146AbaGFTBI (ORCPT ); Sun, 6 Jul 2014 15:01:08 -0400 Received: by mail-wg0-f44.google.com with SMTP id k14so3411739wgh.15 for ; Sun, 06 Jul 2014 12:01:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zyR+ehF0FMufyHRfP4cCwHP+hYwIr6+eIjJ/+El7H6E=; b=B7msgCvXgejzmgOUXqoYUFizkqbUfGGaodSdAbcSVj9f4ey5zBv2G1WasClzalTRTK WA+iY3RwI/kVLUDgnrJz+5+vwkMEyHoQOU6NGG1hxp/waH3H8CEvBl6zddNEgZ8kop/k Ir0Fy7ZckIFj/u/Y+bE27hypFdby3me/LGGfVLrLSmAIF4zxctRzxZCQVrnrc3QNrKjS zmfaSXMRgqtBh/KyCGoEtVE1lVexzYcq4nkoOZ2/fl9dfXFtrw2nNSKR7LDUQr6mqQKm CjonpMDiCoosVxO++vL8yZUUUsmIFN5vro+2+MbeMgKkfspj9X13/l7z24CJORqITeVd kX3g== X-Gm-Message-State: ALoCoQmTIfyKdIqSN6iI+62N8zB+tsVLlNm8JJIzY4HlR40+QZPoOwmA53ryfkEotD6TOYXBJbm9 X-Received: by 10.180.94.166 with SMTP id dd6mr30834495wib.33.1404673266419; Sun, 06 Jul 2014 12:01:06 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id fu7sm37736099wib.2.2014.07.06.12.01.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jul 2014 12:01:05 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Geert Uytterhoeven , Jingoo Han , Daniel Vetter , Joe Perches , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: valkyriefb.c: Cleaning up variable that is never used Date: Sun, 6 Jul 2014 21:02:22 +0200 Message-Id: <1404673342-20672-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/valkyriefb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video/fbdev/valkyriefb.c index 97cb9bd..af708fe 100644 --- a/drivers/video/fbdev/valkyriefb.c +++ b/drivers/video/fbdev/valkyriefb.c @@ -416,18 +416,18 @@ static int read_valkyrie_sense(struct fb_info_valkyrie *p) out_8(&p->valkyrie_regs->msense.r, 0); /* release all lines */ __delay(20000); - sense = ((in = in_8(&p->valkyrie_regs->msense.r)) & 0x70) << 4; + sense = ((in_8(&p->valkyrie_regs->msense.r)) & 0x70) << 4; /* drive each sense line low in turn and collect the other 2 */ out_8(&p->valkyrie_regs->msense.r, 4); /* drive A low */ __delay(20000); - sense |= ((in = in_8(&p->valkyrie_regs->msense.r)) & 0x30); + sense |= ((in_8(&p->valkyrie_regs->msense.r)) & 0x30); out_8(&p->valkyrie_regs->msense.r, 2); /* drive B low */ __delay(20000); sense |= ((in = in_8(&p->valkyrie_regs->msense.r)) & 0x40) >> 3; sense |= (in & 0x10) >> 2; out_8(&p->valkyrie_regs->msense.r, 1); /* drive C low */ __delay(20000); - sense |= ((in = in_8(&p->valkyrie_regs->msense.r)) & 0x60) >> 5; + sense |= ((in_8(&p->valkyrie_regs->msense.r)) & 0x60) >> 5; out_8(&p->valkyrie_regs->msense.r, 7);