From patchwork Sun Jul 6 19:03:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4491561 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 85BF29F36A for ; Sun, 6 Jul 2014 19:02:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B9A7420253 for ; Sun, 6 Jul 2014 19:02:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8DE02024C for ; Sun, 6 Jul 2014 19:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752294AbaGFTCK (ORCPT ); Sun, 6 Jul 2014 15:02:10 -0400 Received: from mail-we0-f180.google.com ([74.125.82.180]:44891 "EHLO mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbaGFTCJ (ORCPT ); Sun, 6 Jul 2014 15:02:09 -0400 Received: by mail-we0-f180.google.com with SMTP id x48so3463677wes.11 for ; Sun, 06 Jul 2014 12:02:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ml6MEUMYhYl5vfBGFlqs5TXDQLEPillgPSV7+181iLo=; b=icqkFTPZ4lGwGN88Zbs3Mclh3ISjoo2Sy93oVnGp0u30HcenG9eUaeNP1LPIBzGRsz VP4kSsLyJz+XKrBxizPLAAs86HRGEWgfuxiDOy+1ziP9AJXAX05eJq6bXFYTogMZjyO0 OT6aLYdDxXE8HIAELu6zan/oFzYDr5IPcTobKrgopzP9FprBNxt7aYESnjhe/PJnK3dn yNEfmvW+9Lr+LPQo/osOGPi+Rr8QSzRNqof1SJzh1MWeYujvP97nj6Wbgs1k0TYTo8ur uIL+zzvB4dpcqTYKk5qr/nPhFPLsAbeCt7iBsBoCRFXjVZFN2zYrX18Yc1FqCeVh/g/b xVVw== X-Gm-Message-State: ALoCoQnnwXVvaSJbEqvDVjpSk/LbhZTE59DBD7gNYO9VwN9dYzho2GEYnt72tpDvZYx1gmG8ilrZ X-Received: by 10.180.10.98 with SMTP id h2mr32120380wib.29.1404673328328; Sun, 06 Jul 2014 12:02:08 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id ek3sm84212822wjd.17.2014.07.06.12.02.06 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jul 2014 12:02:07 -0700 (PDT) From: Rickard Strandqvist To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Rickard Strandqvist , Jingoo Han , Laurent Pinchart , Rob Clark , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: fbdev: via: lcd.c: Cleaning up variable that is never used Date: Sun, 6 Jul 2014 21:03:24 +0200 Message-Id: <1404673404-20755-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/video/fbdev/via/lcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/via/lcd.c b/drivers/video/fbdev/via/lcd.c index 5d21ff4..c15ed30 100644 --- a/drivers/video/fbdev/via/lcd.c +++ b/drivers/video/fbdev/via/lcd.c @@ -551,11 +551,11 @@ void viafb_lcd_set_mode(const struct fb_var_screeninfo *var, u16 cxres, u32 clock; struct via_display_timing timing; struct fb_var_screeninfo panel_var; - const struct fb_videomode *mode_crt_table, *panel_crt_table; + const struct fb_videomode, *panel_crt_table; DEBUG_MSG(KERN_INFO "viafb_lcd_set_mode!!\n"); /* Get mode table */ - mode_crt_table = viafb_get_best_mode(set_hres, set_vres, 60); + viafb_get_best_mode(set_hres, set_vres, 60); /* Get panel table Pointer */ panel_crt_table = viafb_get_best_mode(panel_hres, panel_vres, 60); viafb_fill_var_timing_info(&panel_var, panel_crt_table);