From patchwork Mon Aug 18 21:13:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pranith Kumar X-Patchwork-Id: 4739281 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 990A0C033A for ; Mon, 18 Aug 2014 21:14:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D4DA120120 for ; Mon, 18 Aug 2014 21:14:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04C7C20142 for ; Mon, 18 Aug 2014 21:14:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751941AbaHRVN4 (ORCPT ); Mon, 18 Aug 2014 17:13:56 -0400 Received: from mail-yk0-f175.google.com ([209.85.160.175]:37589 "EHLO mail-yk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbaHRVNt (ORCPT ); Mon, 18 Aug 2014 17:13:49 -0400 Received: by mail-yk0-f175.google.com with SMTP id q200so4712629ykb.6 for ; Mon, 18 Aug 2014 14:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Xyb0hfdEGUE0sfaYnaHhY+7m/6Y6W3qGBPScEjcIPUU=; b=GAC/8d/uxW3q91pAI6fefZ24kW32oNIt3iCmo7uZ4WhxZmKw0Sb3aDXd/n5j+fzDMH yslyBLVhbq7Dd50j+lDUKO5EFeP/5YYgEZH3WJ5qX15fcnGVLV9sEO+unri2T+D8lM+2 sSq+IckP1B6dwi9BS/fKHcOq5vg+rXxPi46lkiq5BbvHtFulL9j+XExviLKUMAJh4zzA vzc71w0CkeNFknl53uWpKYadTa9zKJZ0390xBE+D7dz4IOew/06BBKiRDreos43h3pzU i+VRzJFEZSK80NlcBQdTKp+R3KOKNnZ6YGcnL1ZK4MhbbqiLkui6UoTtYVcuIwJ5bwSb 9sBQ== X-Received: by 10.236.124.132 with SMTP id x4mr6497282yhh.119.1408396429031; Mon, 18 Aug 2014 14:13:49 -0700 (PDT) Received: from evgadesktop.gateway.pace.com (108-232-152-155.lightspeed.tukrga.sbcglobal.net. [108.232.152.155]) by mx.google.com with ESMTPSA id w3sm38064557yhk.6.2014.08.18.14.13.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Aug 2014 14:13:47 -0700 (PDT) From: Pranith Kumar To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Arnd Bergmann , Peter Griffin , Alexander Shiyan , Jean Delvare , Kukjin Kim , Mark Brown , linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER), linux-kernel@vger.kernel.org (open list) Cc: geert@linux-m68k.org, Andrew Morton Subject: [PATCH] powerpc: Fix build error for vga16fb Date: Mon, 18 Aug 2014 17:13:42 -0400 Message-Id: <1408396422-32658-2-git-send-email-bobby.prani@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1408396422-32658-1-git-send-email-bobby.prani@gmail.com> References: <1408396422-32658-1-git-send-email-bobby.prani@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix a build error caused by drivers/built-in.o: In function `vga16fb_probe': drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' make: *** [vmlinux] Error 1 This is occuring as vgacon_remap_base is exported only when CONFIG_VGA_CONSOLE=y. Fix the error by making FB_VBA16 depend on CONFIG_VGA_CONSOLE. Signed-off-by: Pranith Kumar Reported-by: Geert Uytterhoeven CC: Andrew Morton --- drivers/video/fbdev/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index e911b9c..09df564 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -547,7 +547,7 @@ config FB_IMSTT config FB_VGA16 tristate "VGA 16-color graphics support" - depends on FB && (X86 || PPC) + depends on FB && (X86 || PPC) && CONFIG_VGA_CONSOLE select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT