From patchwork Mon Aug 18 21:40:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pranith Kumar X-Patchwork-Id: 4739301 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5F687C0338 for ; Mon, 18 Aug 2014 21:40:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 83EDB20123 for ; Mon, 18 Aug 2014 21:40:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4D9E2011E for ; Mon, 18 Aug 2014 21:40:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbaHRVkq (ORCPT ); Mon, 18 Aug 2014 17:40:46 -0400 Received: from mail-yk0-f179.google.com ([209.85.160.179]:55383 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752131AbaHRVkp (ORCPT ); Mon, 18 Aug 2014 17:40:45 -0400 Received: by mail-yk0-f179.google.com with SMTP id 142so4776310ykq.38 for ; Mon, 18 Aug 2014 14:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=C+K+rTr4iEn7weg3JWabj9EMfIMwr8hPNPlZ/jJPJbo=; b=VXqgiUP80IBd1q1VpszIC6S+y+WV4Nuhn4NylScyH8aKzhXQ/CEKp+2l5khNyMRieU WF35lyvWusJrai6btSy2QlSByX3BEWmWLvQYsZdb5qzcxMd9FrM2Bohklo9wU4sNGOUR EB05ioxb4cGlc++xvIiM+jSWkWIMlaGIMCJCxCDdFj1fnvVRgT7fQFWPKZlOcgK63PSS l1LnPB7YmZEoCwkpLdRQkQ3Cmblyxg9IQ30uhPinpU3xnYcFu+WLqRb3T/17eeQ1ePZ7 xIzLM6aRs8K0LoIGHM0LKjzLlINvbX6DHFg8HZSdboOgjb/+/79jjIx6W5FcuTyCVqmX leSg== X-Received: by 10.236.2.164 with SMTP id 24mr5785189yhf.126.1408398044596; Mon, 18 Aug 2014 14:40:44 -0700 (PDT) Received: from evgadesktop.gateway.pace.com (108-232-152-155.lightspeed.tukrga.sbcglobal.net. [108.232.152.155]) by mx.google.com with ESMTPSA id n69sm38178930yhl.11.2014.08.18.14.40.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Aug 2014 14:40:43 -0700 (PDT) From: Pranith Kumar To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Arnd Bergmann , Peter Griffin , Jean Delvare , Jingoo Han , Alexander Shiyan , Kukjin Kim , Pawel Moll , linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER), linux-kernel@vger.kernel.org (open list) Cc: geert@linux-m68k.org, Andrew Morton Subject: [PATCH] powerpc: Fix build error caused by vga16fb Date: Mon, 18 Aug 2014 17:40:39 -0400 Message-Id: <1408398042-18241-1-git-send-email-bobby.prani@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP vga16fb causes a build failure on PPC 32 as follows drivers/built-in.o: In function `vga16fb_probe': drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' drivers/video/fbdev/vga16fb.c:1326: undefined reference to `vgacon_remap_base' make: *** [vmlinux] Error 1 It was noted by Geert that in PPC, no one is setting vgacon_remap_base because of which it working on PPC is suspect. Fix the build failure by disabling vga16fb on PPC. Signed-off-by: Pranith Kumar Reported-by: Geert Uytterhoeven CC: Andrew Morton --- drivers/video/fbdev/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index e911b9c..d236fe4 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -547,7 +547,7 @@ config FB_IMSTT config FB_VGA16 tristate "VGA 16-color graphics support" - depends on FB && (X86 || PPC) + depends on FB && X86 select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT