From patchwork Thu Aug 21 12:23:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pranith Kumar X-Patchwork-Id: 4757181 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9C956C0338 for ; Thu, 21 Aug 2014 12:24:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D71BA2017A for ; Thu, 21 Aug 2014 12:24:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C558320170 for ; Thu, 21 Aug 2014 12:24:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754948AbaHUMX5 (ORCPT ); Thu, 21 Aug 2014 08:23:57 -0400 Received: from mail-yk0-f177.google.com ([209.85.160.177]:50443 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754935AbaHUMX4 (ORCPT ); Thu, 21 Aug 2014 08:23:56 -0400 Received: by mail-yk0-f177.google.com with SMTP id 79so7669732ykr.36 for ; Thu, 21 Aug 2014 05:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=ZSlxd/x9rlXrkP8loGUCvr8g5n5HUP+0M4sPyPh9rsQ=; b=OUD34SotqQwwYrZdobQ2NplVSkNL/YjlysyA7256Y789JdYGgtq68gzIlFWP7QqrSN 9x9J1jefxLirjzeUb8IZFAaBODhTAdeMXnODb/M7oGgANJ73dFLnvRhF/8bmpp+ASQoP UCchw8KGIaccMFsrE07RaQCDP9Zll0bz5FULK70EWcAM3EQKpgS7ieEqifI/1kbSH/nJ jKXTXZAKcVjny11YURlsg2UQrIbBLC/a+h2kvD9XUIF/harS/XCxLhdgLaex4gGUOHIh sgZ59clTxZKk0CliZaWBuuADkCiXQtjbS8+HwQGNtRA1F21G9XLkoAvbUP5XbmsDgfiU k/ng== X-Received: by 10.236.19.196 with SMTP id n44mr87190389yhn.83.1408623835529; Thu, 21 Aug 2014 05:23:55 -0700 (PDT) Received: from evgadesktop.gateway.pace.com (108-232-152-155.lightspeed.tukrga.sbcglobal.net. [108.232.152.155]) by mx.google.com with ESMTPSA id h17sm53251243yha.36.2014.08.21.05.23.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 21 Aug 2014 05:23:54 -0700 (PDT) From: Pranith Kumar To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Rob Clark , Jingoo Han , Laurent Pinchart , Daniel Vetter , linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] fbdev: Remove __init from chips_hw_init() to fix build failure Date: Thu, 21 Aug 2014 08:23:57 -0400 Message-Id: <1408623838-8275-1-git-send-email-bobby.prani@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix build failure caused as follows: The function chipsfb_pci_init() references the function __init chips_hw_init(). This is often because chipsfb_pci_init lacks a __init annotation or the annotation of chips_hw_init is wrong. make: *** [drivers] Error 2 by removing the __init annotation from chips_hw_init(). The other thing that could have been done was annotating chipsfb_pci_init(). But that cannot be done since chipsfb_pci_init() is called from non __init functions. Signed-off-by: Pranith Kumar --- drivers/video/fbdev/chipsfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c index 206a66b..59abdc6 100644 --- a/drivers/video/fbdev/chipsfb.c +++ b/drivers/video/fbdev/chipsfb.c @@ -273,7 +273,7 @@ static struct chips_init_reg chips_init_xr[] = { { 0xa8, 0x00 } }; -static void __init chips_hw_init(void) +static void chips_hw_init(void) { int i;