| Message ID | 1413311335-25083-3-git-send-email-balbi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 14/10/14 21:28, Felipe Balbi wrote: > Caused by a copy & paste error. Note that even with > this bug AM437x SK display still works because GPIO > mux mode is always enabled. It's still wrong to mux > somebody else's pin. > > Luckily ball D25 (offset 0x238 - gpio5_8) on AM437x > isn't used for anything. > > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > arch/arm/boot/dts/am437x-sk-evm.dts | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts > index 859ff3d..681be00 100644 > --- a/arch/arm/boot/dts/am437x-sk-evm.dts > +++ b/arch/arm/boot/dts/am437x-sk-evm.dts > @@ -320,8 +320,7 @@ > > lcd_pins: lcd_pins { > pinctrl-single,pins = < > - /* GPIO 5_8 to select LCD / HDMI */ > - 0x238 (PIN_OUTPUT_PULLUP | MUX_MODE7) > + 0x1c (PIN_OUTPUT_PULLUP | MUX_MODE7) /* gpcm_ad7.gpio1_7 */ > >; > }; > }; I didn't verify the offset, but based on the comments this looks fine to me. Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Tomi
HI, On Wed, Oct 15, 2014 at 03:24:20PM +0300, Tomi Valkeinen wrote: > On 14/10/14 21:28, Felipe Balbi wrote: > > Caused by a copy & paste error. Note that even with > > this bug AM437x SK display still works because GPIO > > mux mode is always enabled. It's still wrong to mux > > somebody else's pin. > > > > Luckily ball D25 (offset 0x238 - gpio5_8) on AM437x > > isn't used for anything. > > > > Signed-off-by: Felipe Balbi <balbi@ti.com> > > --- > > arch/arm/boot/dts/am437x-sk-evm.dts | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts > > index 859ff3d..681be00 100644 > > --- a/arch/arm/boot/dts/am437x-sk-evm.dts > > +++ b/arch/arm/boot/dts/am437x-sk-evm.dts > > @@ -320,8 +320,7 @@ > > > > lcd_pins: lcd_pins { > > pinctrl-single,pins = < > > - /* GPIO 5_8 to select LCD / HDMI */ > > - 0x238 (PIN_OUTPUT_PULLUP | MUX_MODE7) > > + 0x1c (PIN_OUTPUT_PULLUP | MUX_MODE7) /* gpcm_ad7.gpio1_7 */ > > >; > > }; > > }; > > I didn't verify the offset, but based on the comments this looks fine to me. > > Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Tony, are you taking this patch ? Looks like it has been forgotten and now it needs to be backported to v3.17 and v3.18 (assuming it's too late for v3.18).
On Thu, Dec 04, 2014 at 08:43:25AM -0600, Felipe Balbi wrote: > HI, > > On Wed, Oct 15, 2014 at 03:24:20PM +0300, Tomi Valkeinen wrote: > > On 14/10/14 21:28, Felipe Balbi wrote: > > > Caused by a copy & paste error. Note that even with > > > this bug AM437x SK display still works because GPIO > > > mux mode is always enabled. It's still wrong to mux > > > somebody else's pin. > > > > > > Luckily ball D25 (offset 0x238 - gpio5_8) on AM437x > > > isn't used for anything. > > > > > > Signed-off-by: Felipe Balbi <balbi@ti.com> > > > --- > > > arch/arm/boot/dts/am437x-sk-evm.dts | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts > > > index 859ff3d..681be00 100644 > > > --- a/arch/arm/boot/dts/am437x-sk-evm.dts > > > +++ b/arch/arm/boot/dts/am437x-sk-evm.dts > > > @@ -320,8 +320,7 @@ > > > > > > lcd_pins: lcd_pins { > > > pinctrl-single,pins = < > > > - /* GPIO 5_8 to select LCD / HDMI */ > > > - 0x238 (PIN_OUTPUT_PULLUP | MUX_MODE7) > > > + 0x1c (PIN_OUTPUT_PULLUP | MUX_MODE7) /* gpcm_ad7.gpio1_7 */ > > > >; > > > }; > > > }; > > > > I didn't verify the offset, but based on the comments this looks fine to me. > > > > Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > > Tony, are you taking this patch ? Looks like it has been forgotten and > now it needs to be backported to v3.17 and v3.18 (assuming it's too late > for v3.18). I'll send a new version and Cc stable.
diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts index 859ff3d..681be00 100644 --- a/arch/arm/boot/dts/am437x-sk-evm.dts +++ b/arch/arm/boot/dts/am437x-sk-evm.dts @@ -320,8 +320,7 @@ lcd_pins: lcd_pins { pinctrl-single,pins = < - /* GPIO 5_8 to select LCD / HDMI */ - 0x238 (PIN_OUTPUT_PULLUP | MUX_MODE7) + 0x1c (PIN_OUTPUT_PULLUP | MUX_MODE7) /* gpcm_ad7.gpio1_7 */ >; }; };
Caused by a copy & paste error. Note that even with this bug AM437x SK display still works because GPIO mux mode is always enabled. It's still wrong to mux somebody else's pin. Luckily ball D25 (offset 0x238 - gpio5_8) on AM437x isn't used for anything. Signed-off-by: Felipe Balbi <balbi@ti.com> --- arch/arm/boot/dts/am437x-sk-evm.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)