From patchwork Thu Feb 5 12:54:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 5784391 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A1E0CBF440 for ; Thu, 5 Feb 2015 12:54:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E772020268 for ; Thu, 5 Feb 2015 12:54:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 250FC20145 for ; Thu, 5 Feb 2015 12:54:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752927AbbBEMyX (ORCPT ); Thu, 5 Feb 2015 07:54:23 -0500 Received: from mail-wi0-f182.google.com ([209.85.212.182]:36078 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752631AbbBEMyV (ORCPT ); Thu, 5 Feb 2015 07:54:21 -0500 Received: by mail-wi0-f182.google.com with SMTP id n3so10308966wiv.3; Thu, 05 Feb 2015 04:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=76JJyiL/7QmyDVR0OVkJCloChRtmLkAd4tpBRGoezvI=; b=ymYyU+B9bKhD3CfEGDnap3Qp69sqysH867VFN84IqjVsSrKhdQmeOYAz3S/aMeFHdv 6mnll5z9eEFA8AHlbl8vzUbmAfNEbOyK00QMPY2NFRDfx+fdqrHwxDOZr5oRjBPK45WD GyFJ5ik0iBn2Rv6QpXKTSfBIrCMD3f7yTROanXRztNaqriRDg0gTCd07CsI6YYKEGjPA COqyfeFgLWrwe6n/3oHEloNKHaGW+VCCHF99LckqT78/FUVy/x574PYc2neOQMvmzNpU zaEqP9veF/w2kK4TFhY9Hv4Hd6jfK9CV9LHNpXk4YsUAA3p6ub93rizbAVReuXIY5fQt 0+cQ== X-Received: by 10.180.20.47 with SMTP id k15mr56537624wie.83.1423140860697; Thu, 05 Feb 2015 04:54:20 -0800 (PST) Received: from tango-charlie.RL.local ([194.72.83.162]) by mx.google.com with ESMTPSA id vh8sm7283372wjc.12.2015.02.05.04.54.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Feb 2015 04:54:19 -0800 (PST) From: Lad Prabhakar To: Florian Tobias Schandinat , Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Lad, Prabhakar" Subject: [PATCH] fbdev: via/via_clock: fix sparse warning Date: Thu, 5 Feb 2015 12:54:08 +0000 Message-Id: <1423140848-5989-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: "Lad, Prabhakar" this patch fixes following sparse warning: via_clock.c:33:12: warning: symbol 'via_slap' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar --- Found this issue on linux-next (gcc version 4.9.2, sparse version 0.4.5-rc1)and applies on top linux-next. drivers/video/fbdev/via/via_clock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/via/via_clock.c b/drivers/video/fbdev/via/via_clock.c index db1e392..bf269fa 100644 --- a/drivers/video/fbdev/via/via_clock.c +++ b/drivers/video/fbdev/via/via_clock.c @@ -30,7 +30,7 @@ #include "global.h" #include "debug.h" -const char *via_slap = "Please slap VIA Technologies to motivate them " +static const char *via_slap = "Please slap VIA Technologies to motivate them " "releasing full documentation for your platform!\n"; static inline u32 cle266_encode_pll(struct via_pll_config pll)