| Message ID | 1425817886-14387-3-git-send-email-sudipm.mukherjee@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2015.03.08 14:31, Sudip Mukherjee wrote: > check if it is already defined before defining SM750LE_REVISION_ID > again and at the same time mention correct data type. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > drivers/staging/sm750fb/ddk750_chip.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h > index 1c78875..e7d27e8 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.h > +++ b/drivers/staging/sm750fb/ddk750_chip.h > @@ -1,7 +1,9 @@ > #ifndef DDK750_CHIP_H__ > #define DDK750_CHIP_H__ > #define DEFAULT_INPUT_CLOCK 14318181 /* Default reference clock */ > -#define SM750LE_REVISION_ID (char)0xfe > +#ifndef SM750LE_REVISION_ID > +#define SM750LE_REVISION_ID ((unsigned char)0xfe) > +#endif Do you need these parantheses? Also, you can now then fix up this line too to avoid a redundant cast in the same patch: sm750_hw.c: if(share->revid == (unsigned char)SM750LE_REVISION_ID){
On Sun, Mar 08, 2015 at 02:59:03PM +0200, Giedrius Statkevi?ius wrote: > On 2015.03.08 14:31, Sudip Mukherjee wrote: > > -#define SM750LE_REVISION_ID (char)0xfe > > +#ifndef SM750LE_REVISION_ID > > +#define SM750LE_REVISION_ID ((unsigned char)0xfe) > > +#endif > > Do you need these parantheses? Also, you can now then fix up this line > too to avoid a redundant cast in the same patch: > sm750_hw.c: if(share->revid == (unsigned char)SM750LE_REVISION_ID){ good idea, thanks. that extra parentheses is for checkpatch warning of complex macro value. i will better send a v2 of the whole series after checking that resource_size_t. regards sudip > > > -- > Thanks, > Giedrius -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h index 1c78875..e7d27e8 100644 --- a/drivers/staging/sm750fb/ddk750_chip.h +++ b/drivers/staging/sm750fb/ddk750_chip.h @@ -1,7 +1,9 @@ #ifndef DDK750_CHIP_H__ #define DDK750_CHIP_H__ #define DEFAULT_INPUT_CLOCK 14318181 /* Default reference clock */ -#define SM750LE_REVISION_ID (char)0xfe +#ifndef SM750LE_REVISION_ID +#define SM750LE_REVISION_ID ((unsigned char)0xfe) +#endif /* This is all the chips recognized by this library */ typedef enum _logical_chip_type_t
check if it is already defined before defining SM750LE_REVISION_ID again and at the same time mention correct data type. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/staging/sm750fb/ddk750_chip.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)