From patchwork Sun Mar 8 12:31:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 5961751 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 845759F2A9 for ; Sun, 8 Mar 2015 12:32:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7DACA202FF for ; Sun, 8 Mar 2015 12:32:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BB91202EB for ; Sun, 8 Mar 2015 12:32:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbbCHMb7 (ORCPT ); Sun, 8 Mar 2015 08:31:59 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:38072 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752226AbbCHMbr (ORCPT ); Sun, 8 Mar 2015 08:31:47 -0400 Received: by pabrd3 with SMTP id rd3so41330925pab.5; Sun, 08 Mar 2015 05:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dBNvPWvEJAGHNJxQHu3iweyp6NzhV6uu/1iuDhbY4ds=; b=mCSAJYZTBi3pT+4O2DkppxKL5z9LxqYcVJnGt3PBi0Px1eGRl5mkBgyUP8x73doxuH 7NF6cJol56SmrqqTNkLCLmwjIa6n4l2VrIgOSj4xefYl15/aDAPYcK27YnxV58/o9Pk7 zkW9v58H42ioTaJVvMYM66JF6xpfDKCOLWR1tYfpWFmw5cDks2PzvLDzGelj8h36Fr52 FAwEN+ACm1aGaRm0ttCdmoTj46H/xDgdGjN1NLbJILWul3D8JuKonbavCYTmpRsde6Qj vOfdkKDUkaOlorsygn3sPL6KwWHXWw12I3ncqJLsBr5x1yMVR2wi1Cq3r15F9TBwrOcD jPkw== X-Received: by 10.70.36.48 with SMTP id n16mr18991792pdj.82.1425817906265; Sun, 08 Mar 2015 05:31:46 -0700 (PDT) Received: from localhost.localdomain ([122.169.150.126]) by mx.google.com with ESMTPSA id n10sm14708530pdp.18.2015.03.08.05.31.43 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 08 Mar 2015 05:31:45 -0700 (PDT) From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: Sudip Mukherjee , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] staging: sm750fb: correctly define SM750LE_REVISION_ID Date: Sun, 8 Mar 2015 18:01:25 +0530 Message-Id: <1425817886-14387-3-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1425817886-14387-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP check if it is already defined before defining SM750LE_REVISION_ID again and at the same time mention correct data type. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm750fb/ddk750_chip.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h index 1c78875..e7d27e8 100644 --- a/drivers/staging/sm750fb/ddk750_chip.h +++ b/drivers/staging/sm750fb/ddk750_chip.h @@ -1,7 +1,9 @@ #ifndef DDK750_CHIP_H__ #define DDK750_CHIP_H__ #define DEFAULT_INPUT_CLOCK 14318181 /* Default reference clock */ -#define SM750LE_REVISION_ID (char)0xfe +#ifndef SM750LE_REVISION_ID +#define SM750LE_REVISION_ID ((unsigned char)0xfe) +#endif /* This is all the chips recognized by this library */ typedef enum _logical_chip_type_t