From patchwork Tue Mar 10 08:51:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Stoakes X-Patchwork-Id: 5975751 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 39606BF440 for ; Tue, 10 Mar 2015 08:52:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5F11520145 for ; Tue, 10 Mar 2015 08:52:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8457C201D3 for ; Tue, 10 Mar 2015 08:52:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750876AbbCJIwI (ORCPT ); Tue, 10 Mar 2015 04:52:08 -0400 Received: from mail-we0-f180.google.com ([74.125.82.180]:42161 "EHLO mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbbCJIwH (ORCPT ); Tue, 10 Mar 2015 04:52:07 -0400 Received: by wesq59 with SMTP id q59so107755wes.9; Tue, 10 Mar 2015 01:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=BG9kit2WT5/cd96Cl7dI8R/Jr+JynWEGnP1tEzP8yrQ=; b=E3cWopt3FfZJ+vaHlLFbkhPghFoZ7B3ETCNLawpNVDS8YSiXbzFPqMYObD4z6ypil9 HSISlyQBvlOQ/q/b980nuAm/Wy40vBBg2lGCjLXVIupPti/ps6gdsK6LKlIzI+S/iBWm D/NuIEaM61qdpZwn0b0kluS5Y8xuIRqbeLv4cRxGdN+IpwZDO7Qw2L3+ldv+BYjjlmn7 FzMOvENjc1yMwCbTZbHRSxw9GEASisd3zMURhVnLQ0L33haRjqmnjbWWPE3DPEMBJF5M zJ7ZSbUDZt9mMU7H/e7Z1otEYsVfsd21gwZwAA3WiPDnOWY30Cn615FTFCsxWNW2Q8mN KKjA== X-Received: by 10.194.83.66 with SMTP id o2mr67375648wjy.55.1425977525560; Tue, 10 Mar 2015 01:52:05 -0700 (PDT) Received: from localhost (cpc71925-newt30-2-0-cust4.19-3.cable.virginm.net. [82.35.188.5]) by mx.google.com with ESMTPSA id vv9sm31988086wjc.35.2015.03.10.01.52.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2015 01:52:04 -0700 (PDT) From: Lorenzo Stoakes To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Lorenzo Stoakes Subject: [PATCH v2] staging: sm750fb: Fix sparse warning Date: Tue, 10 Mar 2015 08:51:59 +0000 Message-Id: <1425977519-4810-1-git-send-email-lstoakes@gmail.com> X-Mailer: git-send-email 2.3.2 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes the following sparse warning:- drivers/staging/sm750fb/ddk750_help.c: warning: incorrect type in assignment (different address spaces) In addition it eliminates an unnecessary volatile. Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/ddk750_chip.h | 4 +++- drivers/staging/sm750fb/ddk750_help.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h index 1c78875..a4e5bcc 100644 --- a/drivers/staging/sm750fb/ddk750_chip.h +++ b/drivers/staging/sm750fb/ddk750_chip.h @@ -3,6 +3,8 @@ #define DEFAULT_INPUT_CLOCK 14318181 /* Default reference clock */ #define SM750LE_REVISION_ID (char)0xfe +#include + /* This is all the chips recognized by this library */ typedef enum _logical_chip_type_t { @@ -70,7 +72,7 @@ logical_chip_type_t getChipType(void); unsigned int calcPllValue(unsigned int request,pll_value_t *pll); unsigned int calcPllValue2(unsigned int,pll_value_t *); unsigned int formatPllReg(pll_value_t *pPLL); -void ddk750_set_mmio(volatile unsigned char *,unsigned short,char); +void ddk750_set_mmio(unsigned char __iomem *,unsigned short,char); unsigned int ddk750_getVMSize(void); int ddk750_initHw(initchip_param_t *); unsigned int getPllValue(clock_type_t clockType, pll_value_t *pPLL); diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c index cc00d2b..6ad4dec 100644 --- a/drivers/staging/sm750fb/ddk750_help.c +++ b/drivers/staging/sm750fb/ddk750_help.c @@ -7,7 +7,7 @@ char revId750 = 0; unsigned short devId750 = 0; /* after driver mapped io registers, use this function first */ -void ddk750_set_mmio(volatile unsigned char * addr,unsigned short devId,char revId) +void ddk750_set_mmio(unsigned char __iomem * addr,unsigned short devId,char revId) { mmio750 = addr; devId750 = devId;