From patchwork Wed Mar 11 01:28:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lorenzo Stoakes X-Patchwork-Id: 5981521 Return-Path: X-Original-To: patchwork-linux-fbdev@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0E1379F318 for ; Wed, 11 Mar 2015 01:30:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4085820383 for ; Wed, 11 Mar 2015 01:30:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6430F20380 for ; Wed, 11 Mar 2015 01:30:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752888AbbCKBaT (ORCPT ); Tue, 10 Mar 2015 21:30:19 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:35133 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752221AbbCKB3M (ORCPT ); Tue, 10 Mar 2015 21:29:12 -0400 Received: by wibbs8 with SMTP id bs8so34947870wib.0; Tue, 10 Mar 2015 18:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=j/TmRC+PWm8dHNVyfZPkwWcP6a9LIAPRw2zvVEWhgCg=; b=gYNSoJ9mjDNm8nSgv33TME+7z2DXlMJ11/kvhnTQOfuyB5io03nvV0cgRUohzTNH7P zGrmlwzNSF86Ra1v78T2BBkncz5Gq98m1ZXL1UYl37pdCcYZTMxqe1XrXqCrxPQCER96 ZK9srLAFKL99wu0dQZH3+o8W56VZjsklXIM9MgicORqYdxhrXeseFc8GR8cMRykrpcVh phW82L4yiPn+MrFuYs39JuBmhJnTFAMZNImPxC4yPkSDALiMNty3c+gJh9pxQ6TJChQB heum9lTJiYu2kbgNZPe8N+HXkFgYFnOnuuvV0UBHresT0bOgTzFvYt7Ho89sb2OcrXYc iR1g== X-Received: by 10.180.109.70 with SMTP id hq6mr35009005wib.16.1426037351077; Tue, 10 Mar 2015 18:29:11 -0700 (PDT) Received: from localhost (cpc71925-newt30-2-0-cust4.19-3.cable.virginm.net. [82.35.188.5]) by mx.google.com with ESMTPSA id e2sm3159148wjy.46.2015.03.10.18.29.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2015 18:29:09 -0700 (PDT) From: Lorenzo Stoakes To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Lorenzo Stoakes Subject: [PATCH 4/6] staging: sm750fb: Expose hw712_fillrect externally Date: Wed, 11 Mar 2015 01:28:43 +0000 Message-Id: <1426037325-8392-4-git-send-email-lstoakes@gmail.com> X-Mailer: git-send-email 2.3.2 In-Reply-To: <1426037325-8392-1-git-send-email-lstoakes@gmail.com> References: <1426037325-8392-1-git-send-email-lstoakes@gmail.com> Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds a reference to hw712_fillrect which is not used elsewhere in the driver, but appears to be an alternative to the hw_fillrect method. This patch fixes the following sparse warning:- drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' was not declared. Should it be static? Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750_accel.c | 2 +- drivers/staging/sm750fb/sm750_accel.h | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 4aa763b..6521c3b 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -92,7 +92,7 @@ void hw_set2dformat(struct lynx_accel * accel,int fmt) /* seems sm712 RectFill command is broken,so need use BitBlt to * replace it. */ -static int hw712_fillrect(struct lynx_accel * accel, +int hw712_fillrect(struct lynx_accel * accel, u32 base,u32 pitch,u32 Bpp, u32 x,u32 y,u32 width,u32 height, u32 color,u32 rop) diff --git a/drivers/staging/sm750fb/sm750_accel.h b/drivers/staging/sm750fb/sm750_accel.h index 3ee0bd8..51a9367 100644 --- a/drivers/staging/sm750fb/sm750_accel.h +++ b/drivers/staging/sm750fb/sm750_accel.h @@ -238,11 +238,16 @@ void hw_set2dformat(struct lynx_accel * accel,int fmt); void hw_de_init(struct lynx_accel * accel); +int hw712_fillrect(struct lynx_accel * accel, + u32 base,u32 pitch,u32 Bpp, + u32 x,u32 y,u32 width,u32 height, + u32 color,u32 rop); + int hw_fillrect(struct lynx_accel * accel, u32 base,u32 pitch,u32 Bpp, u32 x,u32 y,u32 width,u32 height, u32 color,u32 rop); int hw_copyarea( struct lynx_accel * accel, unsigned int sBase, /* Address of source: offset in frame buffer */